third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 2420203002: Implement convertToBlob() in OffscreenCanvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 2420203002: Implement convertToBlob() in OffscreenCanvas (Closed)

Patch Set: fix layout test and reviewer feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index 075df5f754dae124dc6a7bb2b6fc6dac393021cc..94474b0d790fee02c2c28d6b3d5270e291d651e6 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -745,10 +745,9 @@ void HTMLCanvasElement::toBlob(BlobCallback* callback,

CanvasAsyncBlobCreator* asyncCreator = CanvasAsyncBlobCreator::create(

imageData->data(), encodingMimeType, imageData->size(), callback,

- startTime, document());

+ startTime, &document());

- bool useIdlePeriodScheduling = (encodingMimeType != "image/webp");

- asyncCreator->scheduleAsyncBlobCreation(useIdlePeriodScheduling, quality);

+ asyncCreator->scheduleAsyncBlobCreation(quality);

}

void HTMLCanvasElement::addListener(CanvasDrawListener* listener) {