Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 2420203002: Implement convertToBlob() in OffscreenCanvas (Closed)

Created:
4 years, 2 months ago by xlai (Olivia)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement convertToBlob() in OffscreenCanvas This CL implements convertToBlob on OffscreenCanvas for both worker and main threads. The OffscreenCanvasRenderingContext2D cases are complete. For the Webgl rendering context, currently convertToBlob() can only work for PNG image type. BUG=563830 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/c9e12fb8f608b3d0e204b167459bf9ea999e068c Cr-Commit-Position: refs/heads/master@{#427153}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : done #

Patch Set 4 : fix unit test #

Patch Set 5 : webgl layout test #

Total comments: 6

Patch Set 6 : rename function name #

Total comments: 27

Patch Set 7 : fix layout test and reviewer feedback #

Total comments: 2

Patch Set 8 : rebase and fix global-interface-listing-service-worker-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+760 lines, -125 lines) Patch
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-main.html View 1 2 3 4 5 6 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-main-expected.html View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-worker.html View 1 2 3 4 5 6 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-worker-expected.html View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-main.html View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-main-expected.html View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-worker.html View 1 2 3 4 5 6 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-worker-expected.html View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/README.txt View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 1 2 3 4 5 6 6 chunks +33 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 2 3 4 5 6 21 chunks +154 lines, -92 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp View 1 2 3 4 5 6 17 chunks +27 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/offscreencanvas/ImageEncodeOptions.idl View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 1 2 3 4 5 6 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 2 3 4 5 6 2 chunks +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 2 3 4 5 6 7 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
xlai (Olivia)
https://codereview.chromium.org/2420203002/diff/100001/third_party/WebKit/LayoutTests/VirtualTestSuites File third_party/WebKit/LayoutTests/VirtualTestSuites (right): https://codereview.chromium.org/2420203002/diff/100001/third_party/WebKit/LayoutTests/VirtualTestSuites#newcode16 third_party/WebKit/LayoutTests/VirtualTestSuites:16: "args": ["--enable-threaded-compositing"] I just realize that I still need ...
4 years, 2 months ago (2016-10-19 18:51:07 UTC) #6
Justin Novosad
https://codereview.chromium.org/2420203002/diff/140001/third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/README.txt File third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/README.txt (right): https://codereview.chromium.org/2420203002/diff/140001/third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/README.txt#newcode1 third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/README.txt:1: # This suite runs the tests in virtual/threaded/fast/canvas with ...
4 years, 2 months ago (2016-10-19 19:59:33 UTC) #7
xlai (Olivia)
https://codereview.chromium.org/2420203002/diff/140001/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp File third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp (right): https://codereview.chromium.org/2420203002/diff/140001/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp#newcode91 third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp:91: // TODO: Add histograms for OffscreenCanvas.convertToBlob. On 2016/10/19 19:59:32, ...
4 years, 2 months ago (2016-10-20 15:58:54 UTC) #10
Justin Novosad
lgtm with follow-up request https://codereview.chromium.org/2420203002/diff/200001/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h File third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h (right): https://codereview.chromium.org/2420203002/diff/200001/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h#newcode91 third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h:91: virtual ImageData* toImageData(SnapshotReason reason) const ...
4 years, 2 months ago (2016-10-20 16:18:54 UTC) #11
xlai (Olivia)
Sending to more reviewers. haraken@: Please review WebKit/Source/bindings/. ImageEncodeOptions is added based on newly modified ...
4 years, 2 months ago (2016-10-20 16:26:27 UTC) #13
haraken
bindings/ LGTM
4 years, 2 months ago (2016-10-20 16:29:07 UTC) #14
Ken Russell (switch to Gerrit)
webgl lgtm
4 years, 2 months ago (2016-10-22 00:57:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420203002/220001
4 years, 1 month ago (2016-10-24 15:09:33 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/301369)
4 years, 1 month ago (2016-10-24 16:17:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420203002/220001
4 years, 1 month ago (2016-10-24 20:59:14 UTC) #26
commit-bot: I haz the power
Committed patchset #8 (id:220001)
4 years, 1 month ago (2016-10-24 21:20:23 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 21:26:27 UTC) #30
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/c9e12fb8f608b3d0e204b167459bf9ea999e068c
Cr-Commit-Position: refs/heads/master@{#427153}

Powered by Google App Engine
This is Rietveld 408576698