Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2420163002: another SkSL crash fix (Closed)

Created:
4 years, 2 months ago by ethannicholas
Modified:
4 years, 2 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/sksl/SkSLParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
4 years, 2 months ago (2016-10-14 18:36:26 UTC) #3
dogben
lgtm
4 years, 2 months ago (2016-10-14 18:51:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420163002/1
4 years, 2 months ago (2016-10-14 18:51:54 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:14:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd4645b3051ab7944e5609b6d5ce9774d011bfbd

Powered by Google App Engine
This is Rietveld 408576698