Chromium Code Reviews Chromium Code Reviews
Issue 2420133002:
Make module enumeration a low priority background task. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 35fc67d767868d234e086d927a4316f80c21ab2a..d7f3bc8fd2a6ecf21d0fdf3a5e2ad3c33290b1fd 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -6804,6 +6804,60 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Conflicts.ConfirmedBadModules"> |
|
rkaplow
2016/10/17 14:10:15
should have unit="modules" or something
chrisha
2016/10/17 15:32:21
Done.
|
| + <owner>chrisha@chromium.org</owner> |
| + <summary> |
| + The number of confirmed bad modules found during module enumeration. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Conflicts.EnumerateLoadedModules" units="ms"> |
|
rkaplow
2016/10/17 14:10:15
I wish the name was EnumerateLoadedModulesTime or
chrisha
2016/10/17 15:32:21
Acknowledged.
|
| + <owner>chrisha@chromium.org</owner> |
| + <summary> |
| + The length of time it takes to enumerate the loaded modules in the browser |
| + process. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Conflicts.EnumerateShellExtensions" units="ms"> |
| + <owner>chrisha@chromium.org</owner> |
| + <summary> |
| + The length of time it takes to enumerate the shell extensions. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Conflicts.EnumerateWinsockModules" units="ms"> |
| + <owner>chrisha@chromium.org</owner> |
| + <summary> |
| + The length of time it takes to enumerate the Winsock LSP modules. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Conflicts.EnumerationInspectionTime" units="ms"> |
| + <owner>chrisha@chromium.org</owner> |
| + <summary> |
| + The cumulative length of time it takes to inspect all modules on disk, |
| + extracting their certificates and version information. This work is actually |
| + spread out over a much longer period of time so as not to impact the user. |
| + </summary> |
| +</histogram> |
|
chrisha
2016/10/14 18:13:23
I added this one. The rest already existed, but in
|
| + |
| +<histogram name="Conflicts.EnumerationTotalTime" units="ms"> |
| + <owner>chrisha@chromium.org</owner> |
| + <summary> |
| + The cumulative length of time it takes to enumerate and inspect all modules. |
| + This work is actually spread out over a much longer period of time so as not |
| + to impact the user. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Conflicts.SuspectedBadModules"> |
|
rkaplow
2016/10/17 14:10:15
unit here too
chrisha
2016/10/17 15:32:21
Done.
|
| + <owner>chrisha@chromium.org</owner> |
| + <summary> |
| + The number of suspected bad modules found during module enumeration. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="ConnectivityDiagnostics.ChromeOsSignalStrength" units="%"> |
| <owner>ebeach@google.com</owner> |
| <summary> |
