Refactor video capturing code in the render process

content/renderer/media/webrtc/video_destination_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webrtc/video_destination_handler.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/logging.h"
@@ skipping 98 matching lines @@
   libyuv::BGRAToI420(reinterpret_cast<uint8*>(bitmap->getPixels()),
                      bitmap->rowBytes(),
                      new_frame->data(media::VideoFrame::kYPlane),
                      new_frame->stride(media::VideoFrame::kYPlane),
                      new_frame->data(media::VideoFrame::kUPlane),
                      new_frame->stride(media::VideoFrame::kUPlane),
                      new_frame->data(media::VideoFrame::kVPlane),
                      new_frame->stride(media::VideoFrame::kVPlane),
                      frame_size.width(), frame_size.height());
 
-  DeliverVideoFrame(new_frame);
+  // TODO(hclam): Should take into account |timestamp|.
+  // Not all sinks care about the TimeTicks so it's not a problem now.

[Ami GONE FROM CHROMIUM, 2014/04/24 21:04:31]

ditto comment elsewhere, why wouldn't you use |timestamp| from l.98?

[Alpha Left Google, 2014/04/24 22:50:34]

The parameter is a TimeTicks. I would need to save a start time to compute the
correct TimeTicks here.

The reason for using TimeTicks: it is a Chrome wide clock that allows
synchronization of streams. Our camera implementations already provide this but
we drop it in VideoCaptureImpl. I'm adding this back to the interface.

Non-camera implementation of sources can just give TimeTicks::Now().

[Ami GONE FROM CHROMIUM, 2014/04/24 23:05:18]

I'm unclear on why synchronization can't be done using media::VideoFrame's
TimeDeltas (and a per-stream start TimeTicks, which would have to be maintained
by whoever is doing the synchronizing).

[Alpha Left Google, 2014/04/24 23:33:53]

When a frame is captured in the browser. It is tagged with a TimeTicks (Moment
A). Current code in tree trims this to a TimeDelta and set it to VideoFrame in
VCI. Downstream code currently record a stream start TimeTicks (Moment B) and
add the TimeDelta back to obtain a time for synchronization. 

There is a latency between moment A and B. It would be better to just pass along
the TimeTicks untouched.

+  DeliverVideoFrame(new_frame, format_, base::TimeTicks::Now());
 }
 
 // PpFrameWriterProxy is a helper class to make sure the user won't use
 // PpFrameWriter after it is released (IOW its owner - WebMediaStreamSource -
 // is released).
 class PpFrameWriterProxy : public FrameWriterInterface {
  public:
   explicit PpFrameWriterProxy(const base::WeakPtr<PpFrameWriter>& writer)
       : writer_(writer) {
     DCHECK(writer_ != NULL);
@@ skipping 53 matching lines @@
 
   stream.addTrack(MediaStreamVideoTrack::CreateVideoTrack(
       writer, constraints, MediaStreamVideoSource::ConstraintsCallback(),
       track_enabled));
 
   *frame_writer = new PpFrameWriterProxy(writer->AsWeakPtr());
   return true;
 }
 
 }  // namespace content
-