Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: remoting/base/chromoting_event.cc

Issue 2420103003: [Remoting Android] Log app version for telemetry (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/base/chromoting_event.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/chromoting_event.cc
diff --git a/remoting/base/chromoting_event.cc b/remoting/base/chromoting_event.cc
index e7a02eb810ad0a7490e10ab96be9776118973737..51f725d9bf5836a095779d1244652ee01a8d8554 100644
--- a/remoting/base/chromoting_event.cc
+++ b/remoting/base/chromoting_event.cc
@@ -4,6 +4,7 @@
#include "remoting/base/chromoting_event.h"
+#include "base/strings/stringize_macros.h"
#include "base/sys_info.h"
namespace remoting {
@@ -29,6 +30,7 @@ const char ChromotingEvent::kSessionIdKey[] = "session_id";
const char ChromotingEvent::kSessionStateKey[] = "session_state";
const char ChromotingEvent::kTypeKey[] = "type";
const char ChromotingEvent::kVideoBandwidthKey[] = "video_bandwidth";
+const char ChromotingEvent::kWebAppVersionKey[] = "webapp_version";
ChromotingEvent::ChromotingEvent() : values_map_(new base::DictionaryValue()) {}
@@ -82,7 +84,7 @@ void ChromotingEvent::SetDouble(const std::string& key, double value) {
void ChromotingEvent::AddSystemInfo() {
SetString(kCpuKey, base::SysInfo::OperatingSystemArchitecture());
SetString(kOsVersionKey, base::SysInfo::OperatingSystemVersion());
- std::string osName = base::SysInfo::OperatingSystemName();
+ SetString(kWebAppVersionKey, STRINGIZE(VERSION));
#if defined(OS_LINUX)
Os os = Os::CHROMOTING_LINUX;
#elif defined(OS_CHROMEOS)
« no previous file with comments | « remoting/base/chromoting_event.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698