Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 24201002: Open new handle scope when deep copying. (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Open new handle scope when deep copying. R=mstarzinger@chromium.org BUG=292903 Committed: https://code.google.com/p/v8/source/detail?r=16769

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/objects.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 3 months ago (2013-09-17 12:06:16 UTC) #1
Michael Starzinger
LGTM with a nit. https://codereview.chromium.org/24201002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/24201002/diff/1/src/objects.cc#newcode5626 src/objects.cc:5626: HandleScope handle_scope(isolate); nit: You could ...
7 years, 3 months ago (2013-09-17 12:21:01 UTC) #2
Yang
https://codereview.chromium.org/24201002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/24201002/diff/1/src/objects.cc#newcode5626 src/objects.cc:5626: HandleScope handle_scope(isolate); On 2013/09/17 12:21:01, Michael Starzinger wrote: > ...
7 years, 3 months ago (2013-09-17 12:28:19 UTC) #3
Yang
7 years, 3 months ago (2013-09-17 12:28:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698