[wasm] Add inspector test for stack traces

[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=chromium:613110
Committed: https://crrev.com/5b6e39135442f3bd3e19c91d8645533e4e9976ac
Cr-Commit-Position: refs/heads/master@{#40392}

[Clemens Hammacher, 2016-10-14 14:35:15]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 14:35:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 15:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 15:04:16]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-10-17 08:01:27]

Description was changed from

==========
[wasm] Add inspector test

BUG=v8:4203
==========

to

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces shows up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

[Clemens Hammacher, 2016-10-17 08:02:21]

clemensh@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, titzer@chromium.org, yangguo@chromium.org

[Yang, 2016-10-17 09:08:13]

https://codereview.chromium.org/2420093002/diff/1/test/inspector/testcfg.py
File test/inspector/testcfg.py (right):

https://codereview.chromium.org/2420093002/diff/1/test/inspector/testcfg.py#n...
test/inspector/testcfg.py:47: return flags + [ protocoltestfilename,
testfilename ]
Can we have a separate way of adding additional test files instead of
piggybacking them on flags?

[Clemens Hammacher, 2016-10-17 09:34:32]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 09:34:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-17 09:41:04]

https://codereview.chromium.org/2420093002/diff/1/test/inspector/testcfg.py
File test/inspector/testcfg.py (right):

https://codereview.chromium.org/2420093002/diff/1/test/inspector/testcfg.py#n...
test/inspector/testcfg.py:47: return flags + [ protocoltestfilename,
testfilename ]
On 2016/10/17 09:08:13, Yang wrote:
> Can we have a separate way of adding additional test files instead of
> piggybacking them on flags?

Yeah, probably a good idea. This way we can also fix the path separator for
windows.
Done.

[commit-bot: I haz the power, 2016-10-17 10:02:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 10:02:04]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-10-17 11:21:50]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 11:21:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-17 11:23:51]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 11:23:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-17 11:24:16]

Description was changed from

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces shows up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

to

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

[Clemens Hammacher, 2016-10-17 11:25:48]

On 2016/10/17 09:41:04, Clemens Hammacher wrote:
> https://codereview.chromium.org/2420093002/diff/1/test/inspector/testcfg.py
> File test/inspector/testcfg.py (right):
> 
>
https://codereview.chromium.org/2420093002/diff/1/test/inspector/testcfg.py#n...
> test/inspector/testcfg.py:47: return flags + [ protocoltestfilename,
> testfilename ]
> On 2016/10/17 09:08:13, Yang wrote:
> > Can we have a separate way of adding additional test files instead of
> > piggybacking them on flags?
> 
> Yeah, probably a good idea. This way we can also fix the path separator for
> windows.
> Done.

I reworked the patch; it now adds a load() method for inspector tests, similar
to the existing load method in the d8 shell (used in mjsunit tests).

[commit-bot: I haz the power, 2016-10-17 11:50:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 11:50:21]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-17 12:06:24]

lgtm

[kozy, 2016-10-17 13:59:17]

lgtm

[Clemens Hammacher, 2016-10-17 14:14:30]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:14:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 14:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:18:50]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26655)

[Clemens Hammacher, 2016-10-18 08:22:19]

Description was changed from

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

to

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=chromium:613110
==========

[Clemens Hammacher, 2016-10-18 09:56:14]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-10-18 09:56:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 09:58:23]

Description was changed from

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=chromium:613110
==========

to

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=chromium:613110
==========

[commit-bot: I haz the power, 2016-10-18 09:58:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-18 09:58:53]

Description was changed from

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=chromium:613110
==========

to

==========
[wasm] Add inspector test for stack traces

This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG=chromium:613110

Committed: https://crrev.com/5b6e39135442f3bd3e19c91d8645533e4e9976ac
Cr-Commit-Position: refs/heads/master@{#40392}
==========

[commit-bot: I haz the power, 2016-10-18 09:58:54]

Patchset 4 (id:??) landed as
https://crrev.com/5b6e39135442f3bd3e19c91d8645533e4e9976ac
Cr-Commit-Position: refs/heads/master@{#40392}