Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2420043002: Stop re-signaling a slotchange event (Closed)
Patch Set: New slotchange behavior Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Node.h
diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h
index d058ecf64fd38205cc828e79db15d31a5971b5ff..3ebc0c23f2d0cf164b825aee8cf8a67205bc7612 100644
--- a/third_party/WebKit/Source/core/dom/Node.h
+++ b/third_party/WebKit/Source/core/dom/Node.h
@@ -112,6 +112,11 @@ enum class CustomElementState {
NotDefinedFlag = 2 << nodeCustomElementShift,
};
+enum class SlotChangeType {
+ Initial,
+ Chained,
+};
kochi 2016/10/31 08:39:13 nit: clang-format seems to prefer fitting in one l
+
class NodeRareDataBase {
public:
LayoutObject* layoutObject() const { return m_layoutObject; }
@@ -774,9 +779,13 @@ class CORE_EXPORT Node : public EventTarget {
return getFlag(IsFinishedParsingChildrenFlag);
}
- void checkSlotChange();
- void checkSlotChangeAfterInserted() { checkSlotChange(); }
- void checkSlotChangeBeforeRemoved() { checkSlotChange(); }
+ void checkSlotChange(SlotChangeType);
+ void checkSlotChangeAfterInserted() {
+ checkSlotChange(SlotChangeType::Initial);
+ }
+ void checkSlotChangeBeforeRemoved() {
+ checkSlotChange(SlotChangeType::Initial);
+ }
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698