Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 2420033002: [SubZero] Handle relocatable constants for MIPS (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringMIPS32.cpp
diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp
index 331f1ed4c99b6a82b3c3682f1a40810004cf6baa..798813dd92ca7aa68186ab8aab49d0cc6db0d530 100644
--- a/src/IceTargetLoweringMIPS32.cpp
+++ b/src/IceTargetLoweringMIPS32.cpp
@@ -4847,10 +4847,11 @@ Operand *TargetMIPS32::legalize(Operand *From, LegalMask Allowed,
return From;
}
if (auto *C = llvm::dyn_cast<ConstantRelocatable>(From)) {
- (void)C;
- // TODO(reed kotler): complete this case for proper implementation
+ // TODO(jaydeep.patil): Handle ST_Nonsfi case.
Jim Stichnoth 2016/10/16 14:44:43 See my comment in https://codereview.chromium.org/
jaydeep.patil 2016/10/17 04:05:02 Done.
Variable *Reg = makeReg(Ty, RegNum);
- Context.insert<InstFakeDef>(Reg);
+ Variable *TReg = makeReg(Ty, RegNum);
+ _lui(TReg, C, RO_Hi);
+ _addiu(Reg, TReg, C, RO_Lo);
return Reg;
} else if (auto *C32 = llvm::dyn_cast<ConstantInteger32>(From)) {
const uint32_t Value = C32->getValue();

Powered by Google App Engine
This is Rietveld 408576698