Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: runtime/lib/mirrors.cc

Issue 241993004: Mark private functions in dart:* that are native or constructors is not visible (omitted from stack… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 894b3edc89855dfa7f95e6d6355a0f720a33e28a..7c6aecfa2ff21694bd5ef8e2feaec690cd09202f 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -1296,7 +1296,7 @@ DEFINE_NATIVE_ENTRY(ClassMirror_constructors, 2) {
Function& func = Function::Handle();
for (intptr_t i = 0; i < num_functions; i++) {
func ^= functions.At(i);
- if (func.kind() == RawFunction::kConstructor) {
+ if (func.is_visible() && func.kind() == RawFunction::kConstructor) {
constructor_mirror = CreateMethodMirror(func, owner_mirror);
constructor_mirrors.Add(constructor_mirror);
}
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698