Mark private functions in dart:* that are native or constructors is not visible (omitted from stack…

Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation).

Ensure invocation_fuzz_test doesn't exit prematurely.

Also visit instance methods defined in superclasses.

Complete blacklist so invocation_fuzz_test passes on the VM.

B=http://dartbug.com/15274
R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35234

[rmacnak, 2014-04-18 22:07:08]

FWIW, this takes ~2/3 as much time as --compile_all.

[rmacnak, 2014-04-18 22:07:08]

FWIW, this takes ~2/3 as much time as --compile_all.

[Ivan Posva, 2014-04-21 21:18:21]

LGTM -ip

https://codereview.chromium.org/241993004/diff/50001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/241993004/diff/50001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:4092: if (library_.is_dart_scheme() &&
library_.IsPrivate(ctor_name)) {
Please clarify that this hides implicit constructors for _XYZ class such as
class _XYZ {
  var x = 0;
  var y = 'y';
  var z = const Point(0, 0);
}

Is my understanding correct?

[rmacnak, 2014-04-21 23:13:08]

Adjusted stack format test, PTAL.

https://codereview.chromium.org/241993004/diff/50001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/241993004/diff/50001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:4092: if (library_.is_dart_scheme() &&
library_.IsPrivate(ctor_name)) {
On 2014/04/21 21:18:21, Ivan Posva wrote:
> Please clarify that this hides implicit constructors for _XYZ class such as
> class _XYZ {
>   var x = 0;
>   var y = 'y';
>   var z = const Point(0, 0);
> }
> 
> Is my understanding correct?

Yes. Combined with the case above for declared constructors, we are now hiding
all of these in dart:*:

class _HideMe {
  _HideMe();
  _HideMe.public();
  _HideMe._private();
}
class _HideMeImplicit {
}

[Ivan Posva, 2014-04-21 23:21:58]

Still LGTM -ip

[rmacnak, 2014-04-21 23:24:41]

Committed patchset #3 manually as r35234 (presubmit successful).