Remove uses of unittest in the HTML tests where possible.

pkg/dev_compiler/test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],
       function(dart_sdk, async_helper, expect, unittest, require) {
   'use strict';
 
   async_helper = async_helper.async_helper;
   let minitest = expect.minitest;
@@ skipping 392 matching lines @@
       'latin1_test': skip_timeout,
 
       'streamed_conversion_json_encode1_test': skip_timeout,
       'streamed_conversion_json_utf8_decode_test': skip_timeout,
       'streamed_conversion_json_utf8_encode_test': skip_timeout,
       'streamed_conversion_utf8_decode_test': skip_timeout,
       'streamed_conversion_utf8_encode_test': skip_timeout,
       'utf85_test': skip_timeout,
     },
 
-    // TODO(jacobr): enable more of the html tests in unittest once they have
-    // more hope of passing. Triage tests that can never run in this test
-    // runner and track them separately.
     'lib/html': {
       'async_spawnuri_test': async_unittest,
       'async_test': async_unittest,
       'audiobuffersourcenode_test': 'fail', // sdk#27578.
       'audiocontext_test': 'fail', // sdk#27578.
       'blob_constructor_test': 'fail', // sdk#27578.
       'cache_test': 'fail', // sdk#27578.
       'canvas_test': ['unittest'],
       'canvasrenderingcontext2d_test': ['unittest'],
       'cross_domain_iframe_test': async_unittest,
       'crypto_test': 'fail', // sdk#27578.
       'cssstyledeclaration_test': async_unittest,
       'css_test': async_unittest,
 
       // This is failing with a range error, I'm guessing because it's looking
       // for a stylesheet and the page has none.
       'css_rule_list_test': 'fail',
       'custom_element_method_clash_test': async_unittest,
       'custom_element_name_clash_test': async_unittest,
       'custom_elements_23127_test': async_unittest,
       'custom_elements_test': async_unittest,
       'datalistelement_test': 'fail', // sdk#27578.
       'dom_constructors_test': 'fail', // sdk#27578.
       'element_animate_test': async_unittest,
       'element_classes_test': 'fail', // sdk#27579.
       'element_classes_svg_test': 'fail', // sdk#27579.
 
-      // This fails because we get 150 instead of 10 on line 45.
-      'element_dimensions_test': 'fail',
-
-      // Failure: 'Expected 364 to be in the inclusive range [111, 160].'.
+      // Failure: 'Expected 56 to be in the inclusive range [111, 160].'.
       'element_offset_test': 'fail',
       'element_test': async_unittest,
       'element_types_test': 'fail', // sdk#27578.
       'event_customevent_test': async_unittest,
       'events_test': async_unittest,
 
       // Failure: "Failed to execute 'dispatchEvent' on 'EventTarget': parameter
       // 1 is not of type 'Event'."
       'event_test': 'fail',
       'fileapi_test': async_unittest,
       'filereader_test': async_unittest,
       'fontface_loaded_test': async_unittest,
 
       // Failed because it's expecting "Ahem" but getting null. Maybe sdk#27579?
       'fontface_test': 'fail',
       'form_data_test': async_unittest,
       'history_test': async_unittest,
-
-      // Failing because innerHtml should be 'Hello World' but was ''.
-      'htmlelement_test': 'fail',
       'indexeddb_1_test': async_unittest,
       'indexeddb_2_test': async_unittest,
       'indexeddb_3_test': async_unittest,
       'indexeddb_4_test': async_unittest,
       'indexeddb_5_test': async_unittest,
       'input_element_test': 'fail', // sdk#27578.
       'interactive_test': async_unittest,
       'isolates_test': async_unittest,
 
       // Failing on "identical JS objects should have identical proxies".
       'js_test': 'fail',
       'js_interop_1_test': async_unittest,
 
       // Failing because accessing "zSomeInvalidName" does not throw.
       'js_typed_interop_test': 'fail',
 
       // The "typed literal" test fails because the object does not have "_c".
       'js_util_test': 'fail',
-      'keyboard_event_test': ['unittest', 'skip', 'fail'],
-      'localstorage_test': ['unittest', 'skip', 'fail'],
-      'location_test': ['unittest', 'skip', 'fail'],
-      'mediasource_test': ['unittest', 'skip', 'fail'],
-      'media_stream_test': ['unittest', 'skip', 'fail'],
-      'messageevent_test': ['unittest', 'skip', 'fail'],
-      'mirrors_js_typed_interop_test': ['unittest', 'skip', 'fail'],
-      'mouse_event_test': ['unittest', 'skip', 'fail'],
-      'mutationobserver_test': ['unittest', 'skip', 'fail'],
-      'native_gc_test': ['unittest', 'skip', 'fail'],
-      'navigator_test': ['unittest', 'skip', 'fail'],
-      'node_test': ['unittest', 'skip', 'fail'],
-      'node_validator_important_if_you_suppress_make_the_bug_critical_test': ['unittest', 'skip', 'fail'],
-      'non_instantiated_is_test': ['unittest', 'skip', 'fail'],
-      'notification_test': ['unittest', 'skip', 'fail'],
-      'performance_api_test': ['unittest', 'skip', 'fail'],
-      'postmessage_structured_test': ['unittest', 'skip', 'fail'],
-      'private_extension_member_test': ['unittest', 'skip', 'fail'],
-      'queryall_test': ['unittest', 'skip', 'fail'],
-      'query_test': ['unittest', 'skip', 'fail'],
-      'range_test': ['unittest', 'skip', 'fail'],
-      'request_animation_frame_test': ['unittest', 'skip', 'fail'],
-      'resource_http_test': ['unittest', 'skip', 'fail'],
-      'rtc_test': ['unittest', 'skip', 'fail'],
-      'selectelement_test': ['unittest', 'skip', 'fail'],
-      'serialized_script_value_test': ['unittest', 'skip', 'fail'],
-      'shadow_dom_test': ['unittest', 'skip', 'fail'],
-      'shadowroot_test': ['unittest', 'skip', 'fail'],
-      'speechrecognition_test': ['unittest', 'skip', 'fail'],
-      'storage_test': ['unittest', 'skip', 'fail'],
-      'streams_test': ['unittest', 'skip', 'fail'],
-      'svgelement_test': ['unittest', 'skip', 'fail'],
-      'svg_test': ['unittest', 'skip', 'fail'],
-      'table_test': ['unittest', 'skip', 'fail'],
-      'touchevent_test': ['unittest', 'skip', 'fail'],
-      'track_element_constructor_test': ['unittest', 'skip', 'fail'],
-      'transferables_test': ['unittest', 'skip', 'fail'],
-      'transition_event_test': ['unittest', 'skip', 'fail'],
-      'trusted_html_tree_sanitizer_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_1_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_2_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_3_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_4_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_5_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_arraybuffer_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_dataview_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_range_checks_test': ['unittest', 'skip', 'fail'],
-      'typed_arrays_simd_test': ['unittest', 'skip', 'fail'],
-      'typing_test': ['unittest', 'skip', 'fail'],
-      'unknownelement_test': ['unittest', 'skip', 'fail'],
-      'uri_test': ['unittest', 'skip', 'fail'],
-      'url_test': ['unittest', 'skip', 'fail'],
-      'webgl_1_test': ['unittest', 'skip', 'fail'],
-      'websocket_test': ['unittest', 'skip', 'fail'],
-      'websql_test': ['unittest', 'skip', 'fail'],
-      'wheelevent_test': ['unittest', 'skip', 'fail'],
-      'window_eq_test': ['unittest', 'skip', 'fail'],
-      'window_mangling_test': ['unittest', 'skip', 'fail'],
-      'window_nosuchmethod_test': ['unittest', 'skip', 'fail'],
-      'window_test': ['unittest', 'skip', 'fail'],
-      'worker_api_test': ['unittest', 'skip', 'fail'],
-      'worker_test': ['unittest', 'skip', 'fail'],
-      'wrapping_collections_test': ['unittest', 'skip', 'fail'],
-      'xhr_cross_origin_test': ['unittest', 'skip', 'fail'],
-      'xhr_test': ['unittest', 'skip', 'fail'],
-      'xsltprocessor_test': ['unittest', 'skip', 'fail'],
+      'keyboard_event_test': async_unittest,
 
-      'js_typed_interop_default_arg_test_none_multi': ['unittest', 'skip', 'fail'],
-      'js_typed_interop_default_arg_test_explicit_argument_multi': ['unittest', 'skip', 'fail'],
+      'mediasource_test': 'fail', // sdk#27578.
+      'media_stream_test': 'fail', // sdk#27578.
+      'messageevent_test': 'fail', // sdk#27578.
+
+      // Should throw but does not.
+      'mirrors_js_typed_interop_test': 'fail',
+
+      'mutationobserver_test': async_unittest,
+      'native_gc_test': async_unittest,
+      'node_validator_important_if_you_suppress_make_the_bug_critical_test': 'fail', // sdk#27578.
+      'notification_test': 'fail', // sdk#27578.
+      'performance_api_test': 'fail', // sdk#27578.
+      'postmessage_structured_test': async_unittest,
+      'range_test': 'fail', // sdk#27578.
+      'request_animation_frame_test': async_unittest,
+      'resource_http_test': async_unittest,
+      'rtc_test': 'fail', // sdk#27578.
+
+      // Expected 1, got null.
+      'serialized_script_value_test': 'fail',
+      'shadow_dom_test': 'fail', // sdk#27578.
+      'shadowroot_test': 'fail', // sdk#27578.
+      'speechrecognition_test': 'fail', // sdk#27578.
+      'svgelement_test': 'fail', // sdk#27578.
+      'touchevent_test': 'fail', // sdk#27578.
+      'track_element_constructor_test': 'fail', // sdk#27578.
+      'transferables_test': async_unittest,
+      'transition_event_test': async_unittest,
+      'url_test': async_unittest,
+      'websocket_test': async_unittest,
+      'websql_test': async_unittest,
+      'wheelevent_test': async_unittest,
+      'worker_api_test': async_unittest,
+      'worker_test': async_unittest,
+
+      'xhr_cross_origin_test': async_unittest,
+      'xhr_test': async_unittest,
+      'xsltprocessor_test': 'fail', // sdk#27578.
 
       // Failing when it gets 3 instead of 42.
       'js_typed_interop_default_arg_test_default_value_multi': 'fail',
     },
 
     'lib/html/custom': {
-      'attribute_changed_callback_test': ['unittest', 'skip', 'fail'],
-      'constructor_calls_created_synchronously_test':
-        ['unittest', 'skip', 'fail'],
-      'created_callback_test': ['unittest', 'skip', 'fail'],
-      'document_register_basic_test': ['unittest', 'skip', 'fail'],
-      'document_register_type_extensions_test': ['unittest', 'skip', 'fail'],
-      'element_upgrade_test': ['unittest', 'skip', 'fail'],
-      'entered_left_view_test': ['unittest', 'skip', 'fail'],
-      'js_custom_test': ['unittest', 'skip', 'fail'],
-      'mirrors_test': ['unittest', 'skip', 'fail'],
-      'regress_194523002_test': ['unittest', 'skip', 'fail'],
+      'attribute_changed_callback_test': async_unittest,
+      'constructor_calls_created_synchronously_test': async_unittest,
+      'created_callback_test': async_unittest,
+      'entered_left_view_test': async_unittest,
+      'js_custom_test': async_unittest,
+      'mirrors_test': async_unittest,
+      'regress_194523002_test': async_unittest,
     },
 
     'lib/math': {
       // TODO(het): triage
       'double_pow_test': skip_fail,
       'low_test': skip_fail,
       'math_test': skip_fail,
       'math2_test': skip_fail,
       'pi_test': skip_timeout,
       'random_big_test': skip_fail,
@@ skipping 232 matching lines @@
             if (negative) {
               assert.throws(mainLibrary.main);
             } else {
               mainLibrary.main();
             }
           } finally {
             minitest.finishTests();
           }
         }
 
+        // If the test left any lingering detritus in the DOM, blow it away
+        // so it doesn't interfere with later tests.
+        document.body.innerHTML = '';
+        console.log("cleared");

[Jacob, 2016/10/14 16:44:38]

remove console.log message

+
         if (!async_helper.asyncTestStarted) done();
       });
     }
   }
 
   let mochaOnError;
   // We run these tests in a mocha test wrapper to avoid the confusing failure
   // case of dart unittests being interleaved with mocha tests.
   // In practice we are really just suppressing all mocha test behavior while
   // Dart unittests run and then re-enabling it when the dart tests complete.
@@ skipping 48 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 });