ui/aura/window.cc - Issue 241983003: Stops animations when removing a window from its parent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/window.cc

Issue 241983003: Stops animations when removing a window from its parent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Stops animations when removing a layer from its parent and fixes broken test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/window.cc

diff --git a/ui/aura/window.cc b/ui/aura/window.cc

index 2ef70c6b0595dd3170608dff6a96aa71d6757b30..98808ddc2b84aa2946e30ec3835c7c1239ba08a1 100644

--- a/ui/aura/window.cc

+++ b/ui/aura/window.cc

@@ -1007,10 +1007,6 @@ Window* Window::GetWindowForPoint(const gfx::Point& local_point,

}

void Window::RemoveChildImpl(Window* child, Window* new_parent) {

- // Stop (and complete) an ongoing animation to make sure bounds are updated

- // before updating the layers bounds again.

- if (child->layer() && child->layer()->GetAnimator())

- child->layer()->GetAnimator()->StopAnimating();

if (layout_manager_)

layout_manager_->OnWillRemoveWindowFromLayout(child);

FOR_EACH_OBSERVER(WindowObserver, observers_, OnWillRemoveWindow(child));