Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2419803002: Disallow task observers on some BrowserThreads. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow task observers on some BrowserThreads. This CL disallows task observers on the DB, FILE, FILE_USER_BLOCKING, PROCESS_LAUNCHER and CACHE threads. Calling Add/RemoveTaskObserver on these threads will result in a crash. This is important because these threads will be migrated to TaskScheduler which doesn't support task observers. To our knowledge, no code uses task observers on these threads. This CL will help us confirm that in the wild. BUG=653916 Committed: https://crrev.com/dbed8d7df17c48f391fde23becf4cb926079610a Cr-Commit-Position: refs/heads/master@{#425418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M base/message_loop/message_loop.h View 2 chunks +7 lines, -0 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-13 17:35:46 UTC) #6
jam
lgtm
4 years, 2 months ago (2016-10-14 17:31:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419803002/1
4 years, 2 months ago (2016-10-14 17:39:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 19:13:00 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:16:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbed8d7df17c48f391fde23becf4cb926079610a
Cr-Commit-Position: refs/heads/master@{#425418}

Powered by Google App Engine
This is Rietveld 408576698