[Sync] Fix test support targets + duplicate namespaces.

[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
TBR=thestig,caitkp,lazyboy

Committed: https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8
Cr-Commit-Position: refs/heads/master@{#425762}

[maxbogue, 2016-10-15 00:07:54]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:08:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 00:12:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:12:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2016-10-15 00:33:30]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:33:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 00:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:39:04]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2016-10-17 16:56:35]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 16:57:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 17:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:55:46]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-10-17 17:58:01]

Description was changed from

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

test_support_engine is only used internally at this time.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
==========

to

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is not not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
==========

[maxbogue, 2016-10-17 17:58:20]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-10-17 17:58:21]

Sky, PTAL!

[skym, 2016-10-17 19:09:18]

lgtm

[maxbogue, 2016-10-17 19:10:45]

Description was changed from

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is not not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
==========

to

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
==========

[maxbogue, 2016-10-17 19:47:24]

maxbogue@chromium.org changed reviewers:
+ caitkp@chromium.org, lazyboy@chromium.org, thestig@chromium.org

[maxbogue, 2016-10-17 19:47:25]

TBR:

thestig@ - chrome/
caitkp@ - components/
lazyboy@ - extensions/

[maxbogue, 2016-10-17 19:47:58]

Description was changed from

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
==========

to

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
TBR=thestig,caitkp,lazyboy
==========

[maxbogue, 2016-10-17 19:48:05]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:48:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 20:10:06]

Description was changed from

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
TBR=thestig,caitkp,lazyboy
==========

to

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
TBR=thestig,caitkp,lazyboy
==========

[commit-bot: I haz the power, 2016-10-17 20:10:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-17 20:11:54]

Description was changed from

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
TBR=thestig,caitkp,lazyboy
==========

to

==========
[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG=631271
TBR=thestig,caitkp,lazyboy

Committed: https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8
Cr-Commit-Position: refs/heads/master@{#425762}
==========

[commit-bot: I haz the power, 2016-10-17 20:11:56]

Patchset 3 (id:??) landed as
https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8
Cr-Commit-Position: refs/heads/master@{#425762}

[Lei Zhang, 2016-10-17 20:42:50]

lgtm