Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2419793004: Fix jetman_std from corpus tests (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add fixed jetman_std test case The current file cannot be opened with normal PDF viewers. Fixes: - The page tree node Kids array should contain indirect references to the pages, as stated in section 3.6.2 of pdf spec 1.7. In this case, there is a single page. Its description was moved to a separate obj. - The page tree node should contain a Count key, in this case 1. This can also be seen from section 3.6.2. - startref is a typo, and should be startxref. Original jetman_std test case left intact. TEST=file can now be opened with other pdf viewers. pdfium_test can still render the pdf file. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/4f292415c5f73cbb54a55054e720615a9ee444e2

Patch Set 1 #

Patch Set 2 : Add new test instead of replace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A fx/other/jetman_std_fixed.pdf View 1 1 chunk +10 lines, -0 lines 0 comments Download
A + fx/other/jetman_std_fixed_expected.pdf.0.png View 1 Binary file 0 comments Download

Messages

Total messages: 13 (6 generated)
npm
PTAL
4 years, 2 months ago (2016-10-14 18:14:04 UTC) #3
Tom Sepez
On 2016/10/14 18:14:04, npm wrote: > PTAL I kinda like the idea of having the ...
4 years, 2 months ago (2016-10-14 19:02:53 UTC) #5
npm
On 2016/10/14 19:02:53, Tom Sepez wrote: > On 2016/10/14 18:14:04, npm wrote: > > PTAL ...
4 years, 2 months ago (2016-10-14 19:35:01 UTC) #6
Lei Zhang
On 2016/10/14 19:35:01, npm wrote: > On 2016/10/14 19:02:53, Tom Sepez wrote: > > On ...
4 years, 2 months ago (2016-10-14 19:41:37 UTC) #7
npm
PTAL
4 years, 2 months ago (2016-10-17 15:13:50 UTC) #8
dsinclair
lgtm w/ updated description.
4 years, 2 months ago (2016-10-17 15:16:04 UTC) #10
npm
4 years, 2 months ago (2016-10-17 15:28:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4f292415c5f73cbb54a55054e720615a9ee444e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698