Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/isolate.cc

Issue 2419783004: [heap] Reland "Cancel tasks before tearing down the heap." (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cancelable-task.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index a15b1cf345ee00f6740e7e412aee7a745359ffa1..cbde8ac562bd515f706e639f4f2710a068f94463 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2227,13 +2227,14 @@ void Isolate::Deinit() {
delete heap_profiler_;
heap_profiler_ = NULL;
+ cancelable_task_manager()->CancelAndWait();
+
heap_.TearDown();
logger_->TearDown();
delete interpreter_;
interpreter_ = NULL;
- cancelable_task_manager()->CancelAndWait();
delete compiler_dispatcher_tracer_;
compiler_dispatcher_tracer_ = nullptr;
« no previous file with comments | « src/cancelable-task.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698