Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Side by Side Diff: src/isolate.cc

Issue 2419783004: [heap] Reland "Cancel tasks before tearing down the heap." (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/cancelable-task.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/isolate.h" 5 #include "src/isolate.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <fstream> // NOLINT(readability/streams) 9 #include <fstream> // NOLINT(readability/streams)
10 #include <sstream> 10 #include <sstream>
(...skipping 2209 matching lines...) Expand 10 before | Expand all | Expand 10 after
2220 delete runtime_profiler_; 2220 delete runtime_profiler_;
2221 runtime_profiler_ = NULL; 2221 runtime_profiler_ = NULL;
2222 } 2222 }
2223 2223
2224 delete basic_block_profiler_; 2224 delete basic_block_profiler_;
2225 basic_block_profiler_ = NULL; 2225 basic_block_profiler_ = NULL;
2226 2226
2227 delete heap_profiler_; 2227 delete heap_profiler_;
2228 heap_profiler_ = NULL; 2228 heap_profiler_ = NULL;
2229 2229
2230 cancelable_task_manager()->CancelAndWait();
2231
2230 heap_.TearDown(); 2232 heap_.TearDown();
2231 logger_->TearDown(); 2233 logger_->TearDown();
2232 2234
2233 delete interpreter_; 2235 delete interpreter_;
2234 interpreter_ = NULL; 2236 interpreter_ = NULL;
2235 2237
2236 cancelable_task_manager()->CancelAndWait();
2237 2238
2238 delete compiler_dispatcher_tracer_; 2239 delete compiler_dispatcher_tracer_;
2239 compiler_dispatcher_tracer_ = nullptr; 2240 compiler_dispatcher_tracer_ = nullptr;
2240 2241
2241 delete cpu_profiler_; 2242 delete cpu_profiler_;
2242 cpu_profiler_ = NULL; 2243 cpu_profiler_ = NULL;
2243 2244
2244 code_event_dispatcher_.reset(); 2245 code_event_dispatcher_.reset();
2245 2246
2246 delete root_index_map_; 2247 delete root_index_map_;
(...skipping 1209 matching lines...) Expand 10 before | Expand all | Expand 10 after
3456 // Then check whether this scope intercepts. 3457 // Then check whether this scope intercepts.
3457 if ((flag & intercept_mask_)) { 3458 if ((flag & intercept_mask_)) {
3458 intercepted_flags_ |= flag; 3459 intercepted_flags_ |= flag;
3459 return true; 3460 return true;
3460 } 3461 }
3461 return false; 3462 return false;
3462 } 3463 }
3463 3464
3464 } // namespace internal 3465 } // namespace internal
3465 } // namespace v8 3466 } // namespace v8
OLDNEW
« no previous file with comments | « src/cancelable-task.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698