Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 2419783003: [Mac] Fix an ESC key issue with the find bar on Sierra (Closed)

Created:
4 years, 2 months ago by spqchan
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix an ESC key issue with the find bar on Sierra Prevent the window from handling the ESC key when the find bar text is focused on Sierra. BUG=628979 Review-Url: https://codereview.chromium.org/2398303002 Cr-Commit-Position: refs/heads/master@{#424279} (cherry picked from commit 795ed3707fefc9d39d836545d860f216df620c66) Committed: https://chromium.googlesource.com/chromium/src/+/d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm View 2 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
4 years, 2 months ago (2016-10-13 21:02:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1.

Powered by Google App Engine
This is Rietveld 408576698