Add retry and lasterror parameters to DMServer requests.

Add retry and lasterror parameters to DMServer requests.

Parameter retry=true/false is added to every request, lasterror=x is added if the request is a retry, and contains the NET_ERROR code.

BUG=655637
Committed: https://crrev.com/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8
Cr-Commit-Position: refs/heads/master@{#425028}

[Marton Hunyady, 2016-10-13 13:54:23]

hunyadym@chromium.org changed reviewers:
+ atwilson@chromium.org

[Marton Hunyady, 2016-10-13 13:54:24]

PTAL

[Marton Hunyady, 2016-10-13 13:55:00]

The CQ bit was checked by hunyadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 13:55:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Andrew T Wilson (Slow), 2016-10-13 13:57:09]

On 2016/10/13 13:54:24, Marton wrote:
> PTAL

Don't forget to add a BUG number to the CL description. Also might want to
describe exactly when we're adding those params.

[Andrew T Wilson (Slow), 2016-10-13 14:03:13]

lgtm

https://codereview.chromium.org/2419783002/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/device_management_service.cc (right):

https://codereview.chromium.org/2419783002/diff/20001/components/policy/core/...
components/policy/core/common/cloud/device_management_service.cc:338:
std::make_pair(dm_protocol::kParamRetry, "false"));
This is fine, or you could just omit it.

[Marton Hunyady, 2016-10-13 14:13:28]

Description was changed from

==========
Add retry and lasterror parameters to DMServer requests.

BUG=
==========

to

==========
Add retry and lasterror parameters to DMServer requests.

Parameter retry=true/false is added to every request, lasterror=x is added if
the request is a retry, and contains the NET_ERROR code.

BUG=655637
==========

[Marton Hunyady, 2016-10-13 14:17:19]

https://codereview.chromium.org/2419783002/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/device_management_service.cc (right):

https://codereview.chromium.org/2419783002/diff/20001/components/policy/core/...
components/policy/core/common/cloud/device_management_service.cc:338:
std::make_pair(dm_protocol::kParamRetry, "false"));
On 2016/10/13 14:03:13, Andrew T Wilson (Slow) wrote:
> This is fine, or you could just omit it.

I planned to send it so we see immediately (without checking the version) if
it's the first fetch or a retry from an old version of Chrome which doesn't send
the parameter yet.

[commit-bot: I haz the power, 2016-10-13 14:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 14:44:18]

Dry run: This issue passed the CQ dry run.

[Marton Hunyady, 2016-10-13 14:45:52]

The CQ bit was checked by hunyadym@chromium.org

[commit-bot: I haz the power, 2016-10-13 14:46:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 14:49:58]

Description was changed from

==========
Add retry and lasterror parameters to DMServer requests.

Parameter retry=true/false is added to every request, lasterror=x is added if
the request is a retry, and contains the NET_ERROR code.

BUG=655637
==========

to

==========
Add retry and lasterror parameters to DMServer requests.

Parameter retry=true/false is added to every request, lasterror=x is added if
the request is a retry, and contains the NET_ERROR code.

BUG=655637
==========

[commit-bot: I haz the power, 2016-10-13 14:49:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 14:53:34]

Description was changed from

==========
Add retry and lasterror parameters to DMServer requests.

Parameter retry=true/false is added to every request, lasterror=x is added if
the request is a retry, and contains the NET_ERROR code.

BUG=655637
==========

to

==========
Add retry and lasterror parameters to DMServer requests.

Parameter retry=true/false is added to every request, lasterror=x is added if
the request is a retry, and contains the NET_ERROR code.

BUG=655637

Committed: https://crrev.com/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8
Cr-Commit-Position: refs/heads/master@{#425028}
==========

[commit-bot: I haz the power, 2016-10-13 14:53:35]

Patchset 2 (id:??) landed as
https://crrev.com/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8
Cr-Commit-Position: refs/heads/master@{#425028}