Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2419773002: Fix buffer type for JPEG hardware decoder (Closed)

Created:
4 years, 2 months ago by henryhsu
Modified:
4 years, 2 months ago
Reviewers:
wuchengli, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix buffer type for JPEG hardware decoder Driver doesn't support MPLANE buffer type. BUG=655228 TEST=run apprtc and see jpeg decoder histogram Committed: https://crrev.com/29f4cea2627d12fd92146c247a399825ea172e40 Cr-Commit-Position: refs/heads/master@{#424995}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/generic_v4l2_device.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
henryhsu
PTAL
4 years, 2 months ago (2016-10-13 09:02:47 UTC) #2
wuchengli
lgtm https://codereview.chromium.org/2419773002/diff/1/media/gpu/generic_v4l2_device.cc File media/gpu/generic_v4l2_device.cc (right): https://codereview.chromium.org/2419773002/diff/1/media/gpu/generic_v4l2_device.cc#newcode437 media/gpu/generic_v4l2_device.cc:437: // TODO(henryhsu): We have to also support MPLANE ...
4 years, 2 months ago (2016-10-13 09:21:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419773002/20001
4 years, 2 months ago (2016-10-13 09:28:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 10:17:27 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 10:19:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29f4cea2627d12fd92146c247a399825ea172e40
Cr-Commit-Position: refs/heads/master@{#424995}

Powered by Google App Engine
This is Rietveld 408576698