third_party/WebKit/LayoutTests/http/tests/webfont/crbug-655076.html - Issue 2419753002: Prevent FontResource load limit timers from restarting during loading

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/webfont/crbug-655076.html

Issue 2419753002: Prevent FontResource load limit timers from restarting during loading (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/webfont/crbug-655076-expected.html » ('j') | third_party/WebKit/Source/core/fetch/FontResource.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style></style>

	3 <div id="container"></div>

	4 <script>

	5 // Regression test for https://crbug.com/655076. Test passes by not crashing in

	6 // debug build.

	7

	8 if (window.testRunner) {

	9 testRunner.waitUntilDone();

	10 setTimeout(() => {

	11 testRunner.notifyDone();

	12 }, 5000);
	Kunihiko Sakamoto 2016/10/13 05:55:19 5000ms is the same as slow-ahem-loading.cgi delay 5000ms is the same as slow-ahem-loading.cgi delay below. Does this work reliably? Shao-Chuan Lee 2016/10/13 06:12:58 It always crashes when the second span is rendered Show quoted text On 2016/10/13 05:55:19, Kunihiko Sakamoto wrote: > 5000ms is the same as slow-ahem-loading.cgi delay below. Does this work > reliably? It always crashes when the second span is rendered at 4000ms, I guess this doesn't matter. Maybe it's better to move notifyDone() right after the second makeSpan() call to make this test faster. Kunihiko Sakamoto 2016/10/13 06:36:18 But resulting document may be different depending Show quoted text On 2016/10/13 06:12:58, Shao-Chuan Lee wrote: > On 2016/10/13 05:55:19, Kunihiko Sakamoto wrote: > > 5000ms is the same as slow-ahem-loading.cgi delay below. Does this work > > reliably? > > It always crashes when the second span is rendered at 4000ms, I guess this > doesn't matter. But resulting document may be different depending on whether the font is loaded or not, and may not match with the expected.html. Show quoted text > Maybe it's better to move notifyDone() right after the second makeSpan() call to > make this test faster. This looks good. Shao-Chuan Lee 2016/10/13 07:14:06 I see. I think it's better to make this test text- Show quoted text On 2016/10/13 06:36:18, Kunihiko Sakamoto wrote: > On 2016/10/13 06:12:58, Shao-Chuan Lee wrote: > > On 2016/10/13 05:55:19, Kunihiko Sakamoto wrote: > > > 5000ms is the same as slow-ahem-loading.cgi delay below. Does this work > > > reliably? > > > > It always crashes when the second span is rendered at 4000ms, I guess this > > doesn't matter. > > But resulting document may be different depending on whether the font is loaded > or not, and may not match with the expected.html. I see. I think it's better to make this test text-only.
	13 }

	14

	15 let container = document.getElementById('container');

	16 let font = 'slow-ahem-loading.cgi?delay=5000';

	17

	18 function makeSpan(family) {

	19 document.styleSheets[0].insertRule(

	20 '@font-face { font-family: ' + family + '; src: url(' + font + '); }', 0);

	21 let span = document.createElement('span');

	22 span.style.fontFamily = family;

	23 span.textContent = 'test';

	24 container.appendChild(span);

	25 }

	26

	27 window.onload = function() {

	28 makeSpan('ahem-1');

	29 setTimeout(() => { makeSpan('ahem-2'); }, 4000);

	30

	31 };

	32 </script>

OLD	NEW