Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: components/prefs/command_line_pref_store.cc

Issue 2419733005: Extract a base class from CommandLinePrefStore (Closed)
Patch Set: nit in comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/command_line_pref_store.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/command_line_pref_store.cc
diff --git a/components/prefs/command_line_pref_store.cc b/components/prefs/command_line_pref_store.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f8a503e5441a6179af878a583f1c2643ac8bebdf
--- /dev/null
+++ b/components/prefs/command_line_pref_store.cc
@@ -0,0 +1,80 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/prefs/command_line_pref_store.h"
+
+#include <string>
+
+#include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
+#include "base/strings/string_number_conversions.h"
+
+CommandLinePrefStore::CommandLinePrefStore(
+ const base::CommandLine* command_line)
+ : command_line_(command_line) {}
+
+CommandLinePrefStore::~CommandLinePrefStore() {}
+
+void CommandLinePrefStore::ApplyStringSwitches(
+ const CommandLinePrefStore::SwitchToPreferenceMapEntry string_switch[],
+ size_t size) {
+ for (size_t i = 0; i < size; ++i) {
+ if (command_line_->HasSwitch(string_switch[i].switch_name)) {
+ SetValue(string_switch[i].preference_path,
+ base::MakeUnique<base::StringValue>(
+ command_line_->GetSwitchValueASCII(
+ string_switch[i].switch_name)),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ }
+ }
+}
+
+void CommandLinePrefStore::ApplyPathSwitches(
+ const CommandLinePrefStore::SwitchToPreferenceMapEntry path_switch[],
+ size_t size) {
+ for (size_t i = 0; i < size; ++i) {
+ if (command_line_->HasSwitch(path_switch[i].switch_name)) {
+ SetValue(
+ path_switch[i].preference_path,
+ base::MakeUnique<base::StringValue>(
+ command_line_->GetSwitchValuePath(path_switch[i].switch_name)
+ .value()),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ }
+ }
+}
+
+void CommandLinePrefStore::ApplyIntegerSwitches(
+ const CommandLinePrefStore::SwitchToPreferenceMapEntry integer_switch[],
+ size_t size) {
+ for (size_t i = 0; i < size; ++i) {
+ if (command_line_->HasSwitch(integer_switch[i].switch_name)) {
+ std::string str_value = command_line_->GetSwitchValueASCII(
+ integer_switch[i].switch_name);
+ int int_value = 0;
+ if (!base::StringToInt(str_value, &int_value)) {
+ LOG(ERROR) << "The value " << str_value << " of "
+ << integer_switch[i].switch_name
+ << " can not be converted to integer, ignoring!";
+ continue;
+ }
+ SetValue(integer_switch[i].preference_path,
+ base::MakeUnique<base::FundamentalValue>(int_value),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ }
+ }
+}
+
+void CommandLinePrefStore::ApplyBooleanSwitches(
+ const CommandLinePrefStore::BooleanSwitchToPreferenceMapEntry
+ boolean_switch_map[], size_t size) {
+ for (size_t i = 0; i < size; ++i) {
+ if (command_line_->HasSwitch(boolean_switch_map[i].switch_name)) {
+ SetValue(boolean_switch_map[i].preference_path,
+ base::MakeUnique<base::FundamentalValue>(
+ boolean_switch_map[i].set_value),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ }
+ }
+}
« no previous file with comments | « components/prefs/command_line_pref_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698