Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: chrome/browser/prefs/command_line_pref_store.h

Issue 2419733005: Extract a base class from CommandLinePrefStore (Closed)
Patch Set: nit in comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/command_line_pref_store.h
diff --git a/chrome/browser/prefs/command_line_pref_store.h b/chrome/browser/prefs/command_line_pref_store.h
deleted file mode 100644
index 735adb6f16cfab05d802fd279fa7ae87fd96e7e2..0000000000000000000000000000000000000000
--- a/chrome/browser/prefs/command_line_pref_store.h
+++ /dev/null
@@ -1,77 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_
-#define CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_
-
-#include "base/command_line.h"
-#include "base/macros.h"
-#include "base/values.h"
-#include "components/prefs/value_map_pref_store.h"
-
-// This PrefStore keeps track of preferences set by command-line switches,
-// such as proxy settings.
-class CommandLinePrefStore : public ValueMapPrefStore {
- public:
- explicit CommandLinePrefStore(const base::CommandLine* command_line);
-
- protected:
- ~CommandLinePrefStore() override;
-
- // Logs a message and returns false if the proxy switches are
- // self-contradictory. Protected so it can be used in unit testing.
- bool ValidateProxySwitches();
-
- private:
- friend class TestCommandLinePrefStore;
-
- struct StringSwitchToPreferenceMapEntry {
- const char* switch_name;
- const char* preference_path;
- };
-
- struct PathSwitchToPreferenceMapEntry {
- const char* switch_name;
- const char* preference_path;
- };
-
- struct IntegerSwitchToPreferenceMapEntry {
- const char* switch_name;
- const char* preference_path;
- };
-
- // |set_value| indicates what the preference should be set to if the switch
- // is present.
- struct BooleanSwitchToPreferenceMapEntry {
- const char* switch_name;
- const char* preference_path;
- bool set_value;
- };
-
- // Using the string and boolean maps, apply command-line switches to their
- // corresponding preferences in this pref store.
- void ApplySimpleSwitches();
-
- // Determines the proxy mode preference from the given proxy switches.
- void ApplyProxyMode();
-
- // Apply the SSL/TLS preferences from the given switches.
- void ApplySSLSwitches();
-
- // Determines whether the background mode is force-disabled.
- void ApplyBackgroundModeSwitches();
-
- // Weak reference.
- const base::CommandLine* command_line_;
-
- // Mappings of command line switches to prefs.
- static const BooleanSwitchToPreferenceMapEntry boolean_switch_map_[];
- static const StringSwitchToPreferenceMapEntry string_switch_map_[];
- static const PathSwitchToPreferenceMapEntry path_switch_map_[];
- static const IntegerSwitchToPreferenceMapEntry integer_switch_map_[];
-
- DISALLOW_COPY_AND_ASSIGN(CommandLinePrefStore);
-};
-
-#endif // CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_unittest.cc ('k') | chrome/browser/prefs/command_line_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698