Extract a base class from CommandLinePrefStore

chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <gtest/gtest.h>
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
-#include "chrome/browser/prefs/command_line_pref_store.h"
+#include "chrome/browser/prefs/chrome_command_line_pref_store.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/proxy_config/proxy_config_dictionary.h"
 #include "components/proxy_config/proxy_config_pref_names.h"
 #include "components/ssl_config/ssl_config_prefs.h"
 #include "ui/base/ui_base_switches.h"
 
 namespace {
 
 const char unknown_bool[] = "unknown_switch";
 const char unknown_string[] = "unknown_other_switch";
 
 }  // namespace
 
-class TestCommandLinePrefStore : public CommandLinePrefStore {
+class TestCommandLinePrefStore : public ChromeCommandLinePrefStore {
  public:
   explicit TestCommandLinePrefStore(base::CommandLine* cl)
-      : CommandLinePrefStore(cl) {}
+      : ChromeCommandLinePrefStore(cl) {}
 
   bool ProxySwitchesAreValid() {
     return ValidateProxySwitches();
   }
 
   void VerifyProxyMode(ProxyPrefs::ProxyMode expected_mode) {
     const base::Value* value = NULL;
     ASSERT_TRUE(GetValue(proxy_config::prefs::kProxy, &value));
     ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
     ProxyConfigDictionary dict(
@@ skipping 18 matching lines @@
       ASSERT_TRUE((*it)->GetAsString(&cipher_string));
       EXPECT_EQ(*ciphers, cipher_string);
     }
   }
 
  private:
   ~TestCommandLinePrefStore() override {}
 };
 
 // Tests a simple string pref on the command line.
-TEST(CommandLinePrefStoreTest, SimpleStringPref) {
+TEST(ChromeCommandLinePrefStoreTest, SimpleStringPref) {
   base::CommandLine cl(base::CommandLine::NO_PROGRAM);
   cl.AppendSwitchASCII(switches::kLang, "hi-MOM");
-  scoped_refptr<CommandLinePrefStore> store = new CommandLinePrefStore(&cl);
+  scoped_refptr<ChromeCommandLinePrefStore> store =
+      new ChromeCommandLinePrefStore(&cl);
 
   const base::Value* actual = NULL;
   EXPECT_TRUE(store->GetValue(prefs::kApplicationLocale, &actual));
   std::string result;
   EXPECT_TRUE(actual->GetAsString(&result));
   EXPECT_EQ("hi-MOM", result);
 }
 
 // Tests a simple boolean pref on the command line.
-TEST(CommandLinePrefStoreTest, SimpleBooleanPref) {
+TEST(ChromeCommandLinePrefStoreTest, SimpleBooleanPref) {
   base::CommandLine cl(base::CommandLine::NO_PROGRAM);
   cl.AppendSwitch(switches::kNoProxyServer);
   scoped_refptr<TestCommandLinePrefStore> store =
       new TestCommandLinePrefStore(&cl);
 
   store->VerifyProxyMode(ProxyPrefs::MODE_DIRECT);
 }
 
 // Tests a command line with no recognized prefs.
-TEST(CommandLinePrefStoreTest, NoPrefs) {
+TEST(ChromeCommandLinePrefStoreTest, NoPrefs) {
   base::CommandLine cl(base::CommandLine::NO_PROGRAM);
   cl.AppendSwitch(unknown_string);
   cl.AppendSwitchASCII(unknown_bool, "a value");
-  scoped_refptr<CommandLinePrefStore> store = new CommandLinePrefStore(&cl);
+  scoped_refptr<ChromeCommandLinePrefStore> store =
+      new ChromeCommandLinePrefStore(&cl);
 
   const base::Value* actual = NULL;
   EXPECT_FALSE(store->GetValue(unknown_bool, &actual));
   EXPECT_FALSE(store->GetValue(unknown_string, &actual));
 }
 
 // Tests a complex command line with multiple known and unknown switches.
-TEST(CommandLinePrefStoreTest, MultipleSwitches) {
+TEST(ChromeCommandLinePrefStoreTest, MultipleSwitches) {
   base::CommandLine cl(base::CommandLine::NO_PROGRAM);
   cl.AppendSwitch(unknown_string);
   cl.AppendSwitchASCII(switches::kProxyServer, "proxy");
   cl.AppendSwitchASCII(switches::kProxyBypassList, "list");
   cl.AppendSwitchASCII(unknown_bool, "a value");
   scoped_refptr<TestCommandLinePrefStore> store =
       new TestCommandLinePrefStore(&cl);
 
   const base::Value* actual = NULL;
   EXPECT_FALSE(store->GetValue(unknown_bool, &actual));
   EXPECT_FALSE(store->GetValue(unknown_string, &actual));
 
   store->VerifyProxyMode(ProxyPrefs::MODE_FIXED_SERVERS);
 
   const base::Value* value = NULL;
   ASSERT_TRUE(store->GetValue(proxy_config::prefs::kProxy, &value));
   ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
   ProxyConfigDictionary dict(static_cast<const base::DictionaryValue*>(value));
 
   std::string string_result;
 
   ASSERT_TRUE(dict.GetProxyServer(&string_result));
   EXPECT_EQ("proxy", string_result);
 
   ASSERT_TRUE(dict.GetBypassList(&string_result));
   EXPECT_EQ("list", string_result);
 }
 
 // Tests proxy switch validation.
-TEST(CommandLinePrefStoreTest, ProxySwitchValidation) {
+TEST(ChromeCommandLinePrefStoreTest, ProxySwitchValidation) {
   base::CommandLine cl(base::CommandLine::NO_PROGRAM);
 
   // No switches.
   scoped_refptr<TestCommandLinePrefStore> store =
       new TestCommandLinePrefStore(&cl);
   EXPECT_TRUE(store->ProxySwitchesAreValid());
 
   // Only no-proxy.
   cl.AppendSwitch(switches::kNoProxyServer);
   scoped_refptr<TestCommandLinePrefStore> store2 =
@@ skipping 10 matching lines @@
   base::CommandLine cl2(base::CommandLine::NO_PROGRAM);
   cl2.AppendSwitch(switches::kProxyAutoDetect);
   cl2.AppendSwitchASCII(switches::kProxyServer, "server");
   cl2.AppendSwitchASCII(switches::kProxyPacUrl, "url");
   cl2.AppendSwitchASCII(switches::kProxyBypassList, "list");
   scoped_refptr<TestCommandLinePrefStore> store4 =
       new TestCommandLinePrefStore(&cl2);
   EXPECT_TRUE(store4->ProxySwitchesAreValid());
 }
 
-TEST(CommandLinePrefStoreTest, ManualProxyModeInference) {
+TEST(ChromeCommandLinePrefStoreTest, ManualProxyModeInference) {
   base::CommandLine cl1(base::CommandLine::NO_PROGRAM);
   cl1.AppendSwitch(unknown_string);
   cl1.AppendSwitchASCII(switches::kProxyServer, "proxy");
   scoped_refptr<TestCommandLinePrefStore> store1 =
       new TestCommandLinePrefStore(&cl1);
   store1->VerifyProxyMode(ProxyPrefs::MODE_FIXED_SERVERS);
 
   base::CommandLine cl2(base::CommandLine::NO_PROGRAM);
   cl2.AppendSwitchASCII(switches::kProxyPacUrl, "proxy");
   scoped_refptr<TestCommandLinePrefStore> store2 =
         new TestCommandLinePrefStore(&cl2);
   store2->VerifyProxyMode(ProxyPrefs::MODE_PAC_SCRIPT);
 
   base::CommandLine cl3(base::CommandLine::NO_PROGRAM);
   cl3.AppendSwitchASCII(switches::kProxyServer, std::string());
   scoped_refptr<TestCommandLinePrefStore> store3 =
       new TestCommandLinePrefStore(&cl3);
   store3->VerifyProxyMode(ProxyPrefs::MODE_DIRECT);
 }
 
-TEST(CommandLinePrefStoreTest, DisableSSLCipherSuites) {
+TEST(ChromeCommandLinePrefStoreTest, DisableSSLCipherSuites) {
   base::CommandLine cl1(base::CommandLine::NO_PROGRAM);
   cl1.AppendSwitchASCII(switches::kCipherSuiteBlacklist,
                         "0x0004,0x0005");
   scoped_refptr<TestCommandLinePrefStore> store1 =
       new TestCommandLinePrefStore(&cl1);
   const char* const expected_ciphers1[] = {
     "0x0004",
     "0x0005",
   };
   store1->VerifySSLCipherSuites(expected_ciphers1,
@@ skipping 16 matching lines @@
   cl3.AppendSwitchASCII(switches::kCipherSuiteBlacklist,
                         "0x0004;MOAR;0x0005");
   scoped_refptr<TestCommandLinePrefStore> store3 =
       new TestCommandLinePrefStore(&cl3);
   const char* const expected_ciphers3[] = {
     "0x0004;MOAR;0x0005"
   };
   store3->VerifySSLCipherSuites(expected_ciphers3,
                                 arraysize(expected_ciphers3));
 }