Extract a base class from CommandLinePrefStore

chrome/browser/prefs/chrome_command_line_pref_store.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Bernhard Bauer, 2016/10/14 10:06:31]

Update the copyright? Technically this is a new file.

[Menglin, 2016/10/14 17:12:04]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_CHROME_COMMAND_LINE_PREF_STORE_H_
+#define CHROME_BROWSER_PREFS_CHROME_COMMAND_LINE_PREF_STORE_H_
+
+#include "base/command_line.h"
+#include "base/macros.h"
+#include "base/values.h"
+#include "components/prefs/command_line_pref_store.h"
+
+// This PrefStore keeps track of preferences set by command-line switches,
+// such as proxy settings.
+class ChromeCommandLinePrefStore : public CommandLinePrefStore {
+ public:
+  explicit ChromeCommandLinePrefStore(const base::CommandLine* command_line);
+
+ protected:
+  ~ChromeCommandLinePrefStore() override;
+
+  // Logs a message and returns false if the proxy switches are
+  // self-contradictory. Protected so it can be used in unit testing.
+  bool ValidateProxySwitches();

[Bernhard Bauer, 2016/10/14 10:06:31]

Not really your fault, but it's a bit weird to make this protected, just so that
a test can subclass this class *only to call a protected method on it*. And then
on top of that, the subclass is made a (private) friend as well :) We could
probably just make this method public and remove the subclass from the test.
(Also, we shouldn't really log warnings from a test; the production could should
do that if desired.)

If you don't feel like doing that cleanup, could you add a TODO to do it?
Thanks!

[Menglin, 2016/10/14 17:12:04]

ok. for now I add a TODO assigned to you :)

+
+ private:
+  friend class TestCommandLinePrefStore;
+
+  // Using the string and boolean maps, apply command-line switches to their
+  // corresponding preferences in this pref store.
+  void ApplySimpleSwitches();
+
+  // Determines the proxy mode preference from the given proxy switches.
+  void ApplyProxyMode();
+
+  // Apply the SSL/TLS preferences from the given switches.
+  void ApplySSLSwitches();
+
+  // Determines whether the background mode is force-disabled.
+  void ApplyBackgroundModeSwitches();
+
+  // Mappings of command line switches to prefs.
+  static const BooleanSwitchToPreferenceMapEntry boolean_switch_map_[];
+  static const SwitchToPreferenceMapEntry string_switch_map_[];
+  static const SwitchToPreferenceMapEntry path_switch_map_[];
+  static const SwitchToPreferenceMapEntry integer_switch_map_[];
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeCommandLinePrefStore);
+};
+
+#endif  // CHROME_BROWSER_PREFS_CHROME_COMMAND_LINE_PREF_STORE_H_