Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2419733003: Revert of Upgrade libsrtp to version 2.0 (Closed)

Created:
4 years, 2 months ago by Thiemo Nagel
Modified:
4 years, 2 months ago
CC:
chromium-reviews, webrtc-perf-sheriffs_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upgrade libsrtp to version 2.0 (patchset #4 id:60001 of https://codereview.chromium.org/2398073002/ ) Reason for revert: Breaks the build. Reverting on behalf of Matthew. Original issue's description: > Upgrade libsrtp to version 2.0 > > Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. > > https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63..eccff9b52186 > > $ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s' > 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC > 2016-10-10 kjellander Make libsrtp configuration public > 2016-10-06 kjellander Update libsrtp to version 2.0 > > BUG=webrtc:6376 > > Committed: https://crrev.com/bf2e39f3e02a38491c70fa15897b0dcde1f77fba > Cr-Commit-Position: refs/heads/master@{#425002} TBR=jochen@chromium.org,kjellander@chromium.org,mmoroz@chromium.org,mattdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6376 Committed: https://crrev.com/8d42c040b24a03c47e418911e3efb1901f76090b Cr-Commit-Position: refs/heads/master@{#425006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M BUILD.gn View 1 chunk +14 lines, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/libfuzzer/fuzzers/libsrtp_fuzzer.cc View 4 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Thiemo Nagel
Created Revert of Upgrade libsrtp to version 2.0
4 years, 2 months ago (2016-10-13 12:21:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419733003/1
4 years, 2 months ago (2016-10-13 12:21:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 12:22:54 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d42c040b24a03c47e418911e3efb1901f76090b Cr-Commit-Position: refs/heads/master@{#425006}
4 years, 2 months ago (2016-10-13 12:24:57 UTC) #6
kjellander_chromium
On 2016/10/13 12:24:57, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 2 months ago (2016-10-13 13:10:32 UTC) #7
Thiemo Nagel
4 years, 2 months ago (2016-10-13 13:39:57 UTC) #8
Message was sent while issue was closed.
On 2016/10/13 13:10:32, kjellander_chromium wrote:
> On 2016/10/13 12:24:57, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/8d42c040b24a03c47e418911e3efb1901f76090b
> > Cr-Commit-Position: refs/heads/master@{#425006}
> 
> Lgtm and thanks for reverting, but could you include a link to a failed build
as
> well?

http://build.chromium.org/p/chromium/builders/Win/builds/48027

In case that wasn't clear from my message: Matthew had asked me to revert.

Powered by Google App Engine
This is Rietveld 408576698