Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: services/service_manager/README.md

Issue 2419723002: Move services/shell to services/service_manager (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/service_manager/OWNERS ('k') | services/service_manager/background/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/README.md
diff --git a/services/shell/README.md b/services/service_manager/README.md
similarity index 97%
rename from services/shell/README.md
rename to services/service_manager/README.md
index b64423328d5c886f55ef1c3f29497c00664345fe..40d3209f7df6a351908a92bc60467e31e26133b8 100644
--- a/services/shell/README.md
+++ b/services/service_manager/README.md
@@ -90,11 +90,11 @@ Consider this simple application that implements the Service interface:
**app.cc:**
#include “"mojo/public/c/system/main.h”"
- #include “"services/shell/public/cpp/application_runner.h”"
- #include “"services/shell/public/cpp/connector.h”"
- #include “"services/shell/public/cpp/connection.h”"
- #include “"services/shell/public/cpp/identity.h”"
- #include “"services/shell/public/cpp/service.h”"
+ #include “"services/service_manager/public/cpp/application_runner.h”"
+ #include “"services/service_manager/public/cpp/connector.h”"
+ #include “"services/service_manager/public/cpp/connection.h”"
+ #include “"services/service_manager/public/cpp/identity.h”"
+ #include “"services/service_manager/public/cpp/service.h”"
class Service : public shell::Service {
public:
@@ -437,7 +437,7 @@ straightforward. Let’s look at a simple test of our service:
}
The BUILD.gn for this test file looks like any other using the test() template.
-It must also depend on //services/shell/public/cpp:shell_test_support.
+It must also depend on //services/service_manager/public/cpp:shell_test_support.
ServiceTest does a few things, but most importantly it register the test itself
as a Service, with the name you pass it via its constructor. In the example
@@ -458,7 +458,7 @@ the Foo() method return an empty response. In mojo:service, we’d have Foo() tak
the callback as a parameter, and run it. In the test, we spin a RunLoop until we
get that response. In real world cases we can pass back state & validate
expectations. You can see real examples of this test framework in use in the
-Service Manager’s own suite of tests, under //services/shell/tests.
+Service Manager’s own suite of tests, under //services/service_manager/tests.
### Packaging
@@ -557,9 +557,9 @@ Assuming you have an executable that properly initializes the Mojo EDK, you add
the following lines at some point early in application startup to establish the
connection with the Service Manager:
- #include “"services/shell/public/cpp/service.h”"
- #include “"services/shell/public/cpp/service_context.h”"
- #include “"services/shell/runner/child/runner_connection.h”"
+ #include “"services/service_manager/public/cpp/service.h”"
+ #include “"services/service_manager/public/cpp/service_context.h”"
+ #include “"services/service_manager/runner/child/runner_connection.h”"
class MyClient : public shell::Service {
..
« no previous file with comments | « services/service_manager/OWNERS ('k') | services/service_manager/background/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698