Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: base/observer_list_threadsafe.h

Issue 2419673003: Remove base::ObserverList<T>::Iter::GetNext(). (Closed)
Patch Set: ios fix too Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/observer_list_threadsafe.h
diff --git a/base/observer_list_threadsafe.h b/base/observer_list_threadsafe.h
index 49dc859f8f9d1dd72533f81a899e6c24cf50e7de..eb15cd4f4879af60498b33f66acc255235d0b088 100644
--- a/base/observer_list_threadsafe.h
+++ b/base/observer_list_threadsafe.h
@@ -222,11 +222,8 @@ class ObserverListThreadSafe
return;
}
- {
- typename ObserverList<ObserverType>::Iterator it(&context->list);
- ObserverType* obs;
- while ((obs = it.GetNext()) != nullptr)
- method.Run(obs);
+ for (auto& observer : context->list) {
+ method.Run(&observer);
}
// If there are no more observers on the list, we can now delete it.

Powered by Google App Engine
This is Rietveld 408576698