Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2082)

Unified Diff: base/observer_list.h

Issue 2419673003: Remove base::ObserverList<T>::Iter::GetNext(). (Closed)
Patch Set: ios fix too Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/observer_list_threadsafe.h » ('j') | base/observer_list_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/observer_list.h
diff --git a/base/observer_list.h b/base/observer_list.h
index 7543a98180995fba09e4905e78ad1fab275d8d10..8f0be2d639bafc585efd0932cafbd21e42252850 100644
--- a/base/observer_list.h
+++ b/base/observer_list.h
@@ -92,9 +92,6 @@ class ObserverListBase
explicit Iter(ContainerType* list);
~Iter();
- // Deprecated.
- ObserverType* GetNext();
-
// A workaround for C2244. MSVC requires fully qualified type name for
// return type on a function definition to match a function declaration.
using ThisType =
@@ -273,15 +270,6 @@ void ObserverListBase<ObserverType>::Iter<ContainerType>::EnsureValidIndex() {
}
template <class ObserverType>
-template <class ContainerType>
-ObserverType* ObserverListBase<ObserverType>::Iter<ContainerType>::GetNext() {
- EnsureValidIndex();
- ObserverType* current = GetCurrent();
- operator++();
- return current;
-}
-
-template <class ObserverType>
void ObserverListBase<ObserverType>::AddObserver(ObserverType* obs) {
DCHECK(obs);
if (ContainsValue(observers_, obs)) {
« no previous file with comments | « no previous file | base/observer_list_threadsafe.h » ('j') | base/observer_list_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698