Remove base::ObserverList<T>::Iter::GetNext().

base/observer_list_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/observer_list.h"
 #include "base/observer_list_threadsafe.h"
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 887 matching lines @@
 TEST(ObserverListTest, AddObserverInTheLastObserve) {
   using FooList = ObserverList<Foo>;
   FooList observer_list;
 
   AddInObserve<FooList> a(&observer_list);
   Adder b(-1);
 
   a.SetToAdd(&b);
   observer_list.AddObserver(&a);
 
-  FooList::Iterator it(&observer_list);
-  Foo* foo;
-  while ((foo = it.GetNext()) != nullptr)
-    foo->Observe(10);
+  auto it = observer_list.begin();
+  while (it != observer_list.end()) {

[loyso (OOO), 2016/10/16 23:20:17]

nit: you recreate the end iterator many times here (the opposite is to call it
once as in the range-based for loop). It may be a different test :)

+    auto& observer = *it;
+    // Intentionally increment the iterator before calling Observe(). The
+    // ObserverList starts with only one observer, and it == observer_list.end()
+    // should be true after the next line.
+    ++it;
+    // However, the first Observe() call will add a second observer: at this
+    // point, it != observer_list.end() should be true, and Observe() should be
+    // called on the newly added observer on the next iteration of the loop.
+    observer.Observe(10);
+  }
 
   EXPECT_EQ(-10, b.total);
 }
 
 }  // namespace base