Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2419673002: Fix a deprecated declaration warning in interactive_test_utils_mac.mm. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a deprecated declaration warning in interactive_test_utils_mac.mm. The method SetFrontProcess() can be replaced by -[NSApplication activateIgnoringOtherApps:]. BUG=655281 Committed: https://crrev.com/aa6dec0f8ff61d3e46d2c3294b257d8523eaf433 Cr-Commit-Position: refs/heads/master@{#424861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/base/interactive_test_utils_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
thestig: Please review.
4 years, 2 months ago (2016-10-12 20:56:55 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-12 21:00:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419673002/1
4 years, 2 months ago (2016-10-12 21:00:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 21:26:14 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:29:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa6dec0f8ff61d3e46d2c3294b257d8523eaf433
Cr-Commit-Position: refs/heads/master@{#424861}

Powered by Google App Engine
This is Rietveld 408576698