Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2419663005: Only guard the eager compile hint by whether the target literal was same-zone parsed (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only guard the eager compile hint by whether the target literal was same-zone parsed BUG=v8:5501, chromium:655122 Committed: https://crrev.com/8ab5051333809278da565756afd73b3fe39f9e06 Cr-Commit-Position: refs/heads/master@{#40247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/ast/ast.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-13 07:41:50 UTC) #4
marja
lgtm
4 years, 2 months ago (2016-10-13 07:51:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419663005/1
4 years, 2 months ago (2016-10-13 08:30:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 08:33:29 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 08:33:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ab5051333809278da565756afd73b3fe39f9e06
Cr-Commit-Position: refs/heads/master@{#40247}

Powered by Google App Engine
This is Rietveld 408576698