Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2419663003: Remove usage of base::ObserverList<T>::Iter::GetNext() in //ppapi. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
raymes
CC:
chromium-reviews, loyso (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of base::ObserverList<T>::Iter::GetNext() in //ppapi. Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/9fae50227c1e5ded8422e2bada33cc651b268663 Cr-Commit-Position: refs/heads/master@{#425246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ppapi/proxy/ppapi_proxy_test.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
4 years, 2 months ago (2016-10-12 23:38:28 UTC) #4
raymes
lgtm
4 years, 2 months ago (2016-10-14 02:31:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419663003/1
4 years, 2 months ago (2016-10-14 02:32:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 03:21:44 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 03:23:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fae50227c1e5ded8422e2bada33cc651b268663
Cr-Commit-Position: refs/heads/master@{#425246}

Powered by Google App Engine
This is Rietveld 408576698