Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2419613003: VideoCaptureManager: handle case when GetDeviceEntryBySessionId is null (Closed)

Created:
4 years, 2 months ago by mcasas
Modified:
4 years, 2 months ago
Reviewers:
xianglu
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCaptureManager: handle case when GetDeviceEntryBySessionId is null VCM's l.553 uses GetDeviceEntryBySessionId(request->first) without checking the result, that could be null, and is, speculatively, the root cause of the crashes linked in the bug. BUG=655522 Committed: https://crrev.com/124fafd9aae60044673495b39a775a931cbdf90e Cr-Commit-Position: refs/heads/master@{#425072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mcasas
xianglu@ PTAL
4 years, 2 months ago (2016-10-13 14:54:07 UTC) #2
xianglu
lgtm
4 years, 2 months ago (2016-10-13 17:00:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419613003/1
4 years, 2 months ago (2016-10-13 17:08:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 17:13:30 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 17:17:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/124fafd9aae60044673495b39a775a931cbdf90e
Cr-Commit-Position: refs/heads/master@{#425072}

Powered by Google App Engine
This is Rietveld 408576698