Issue 24196004: Collect garbage before serializing heap in test-serialize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24196004: Collect garbage before serializing heap in test-serialize (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Collect garbage before serializing heap in test-serialize BUG=none TEST=nosnap bots with i18n enabled are happy R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16826

Patch Set 2 : updates #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	test/cctest/test-serialize.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nit. https://codereview.chromium.org/24196004/diff/1/test/cctest/test-serialize.cc File test/cctest/test-serialize.cc (right): https://codereview.chromium.org/24196004/diff/1/test/cctest/test-serialize.cc#newcode261 test/cctest/test-serialize.cc:261: internal_isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags, "serialize"); nit: Better use CcTest::i_isolate() ...

7 years, 3 months ago (2013-09-19 11:29:39 UTC) #2

jochen (gone - plz use gerrit)

7 years, 3 months ago (2013-09-19 12:06:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16826.

Expand Messages | Collapse Messages

Issue 24196004: Collect garbage before serializing heap in test-serialize (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages