Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2419563004: Revert of Punt touch UGI deprecation to M56 (Closed)

Created:
4 years, 2 months ago by johnme
Modified:
4 years, 2 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of Punt touch UGI deprecation to M56 (patchset #1 id:1 of https://codereview.chromium.org/2412423003/ ) Reason for revert: This patch breaks compile on the branch, since the "M55" enum value is still used with dopplerWillBeRemoved (note that https://chromium.googlesource.com/chromium/src/+/9848564877f0057f4dcbc98bce061dfa17a9202c removes dopplerWillBeRemoved on master, but that patch is not on the branch) Original issue's description: > Punt touch UGI deprecation to M56 > > BUG=654978 > > Review-Url: https://codereview.chromium.org/2408203004 > Cr-Commit-Position: refs/heads/master@{#424739} > (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) > > Committed: https://chromium.googlesource.com/chromium/src/+/33d95c3c0e29e1263bd81aacbbaa15906abdd278 TBR=rbyers@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
johnme
Created Revert of Punt touch UGI deprecation to M56
4 years, 2 months ago (2016-10-14 14:09:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419563004/1
4 years, 2 months ago (2016-10-14 14:09:52 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 14:12:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698