content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java - Issue 24195023: Switch to sending IME selection updates early.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java

Issue 24195023: Switch to sending IME selection updates early. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tommy's nits Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java ('K') | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java

index 69be5f86e2a3188019a90775fb7c741e001f5025..8cabddb05333a41f892bc4e0489ff36d046b5ec1 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java

@@ -44,22 +44,18 @@ public class AdapterInputConnectionTest extends ContentShellTestBase {

public void testSetComposingText() throws Throwable {

mConnection.setComposingText("t", 1);

assertCorrectState("t", 1, 1, 0, 1, mConnection.getImeStateForTesting());

- mConnection.setEditableText("t", 1, 1, 0, 1);

mWrapper.verifyUpdateSelectionCall(0, 1, 1, 0 ,1);

mConnection.setComposingText("te", 1);

assertCorrectState("te", 2, 2, 0, 2, mConnection.getImeStateForTesting());

- mConnection.setEditableText("te", 2, 2, 0, 2);

mWrapper.verifyUpdateSelectionCall(1, 2, 2, 0 ,2);

mConnection.setComposingText("tes", 1);

assertCorrectState("tes", 3, 3, 0, 3, mConnection.getImeStateForTesting());

- mConnection.setEditableText("tes", 3, 3, 0, 3);

mWrapper.verifyUpdateSelectionCall(2, 3, 3, 0, 3);

mConnection.setComposingText("test", 1);

assertCorrectState("test", 4, 4, 0, 4, mConnection.getImeStateForTesting());

- mConnection.setEditableText("test", 4, 4, 0, 4);

mWrapper.verifyUpdateSelectionCall(3, 4, 4, 0, 4);

}