Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 24195009: Turn HCompareHoleAndBranch into a HUnaryControlInstruction. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Turn HCompareHoleAndBranch into a HUnaryControlInstruction. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Sven, This is straight-forward cleanup. PTAL -- Benedikt
7 years, 3 months ago (2013-09-18 12:14:56 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-18 12:58:00 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-09-19 06:06:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698