Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2419453002: Revert of [inspector] fix timestamp formatting with non C locales (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
kozy, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] fix timestamp formatting with non C locales (patchset #7 id:120001 of https://codereview.chromium.org/2410933002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10548 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] fix timestamp formatting with non C locales > > If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. > > BUG=chromium:653424 > R=dgozman@chromium.org > > Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4 > Cr-Commit-Position: refs/heads/master@{#40190} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653424 Committed: https://crrev.com/36ebaf21c6174dfab08b9bbea97102a3032fd4d9 Cr-Commit-Position: refs/heads/master@{#40200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -214 lines) Patch
M src/inspector/string-16.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/inspector/string-16.cc View 2 chunks +17 lines, -12 lines 0 comments Download
M src/inspector/v8-console.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/v8-console-message.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/inspector/inspector-test.cc View 4 chunks +1 line, -20 lines 0 comments Download
D test/inspector/runtime/protocol-works-with-different-locale.js View 1 chunk +0 lines, -40 lines 0 comments Download
D test/inspector/runtime/protocol-works-with-different-locale-expected.txt View 1 chunk +0 lines, -138 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [inspector] fix timestamp formatting with non C locales
4 years, 2 months ago (2016-10-12 08:18:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419453002/1
4 years, 2 months ago (2016-10-12 08:18:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 08:18:29 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 08:18:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36ebaf21c6174dfab08b9bbea97102a3032fd4d9
Cr-Commit-Position: refs/heads/master@{#40200}

Powered by Google App Engine
This is Rietveld 408576698