Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2419423002: [ignition] Collect feedback for super constructor calls. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Collect feedback for super constructor calls. In order to optimize super constructor calls with ES6 classes, we need some feedback for both the JSCallConstruct and the resulting JSCreate nodes in TurboFan. Both already optimize perfectly when the see nodes with JSFunction constants, so utilizing the existing CallIC machinery here, enables us to optimize the super constructor calls right now w/o a lot of effort. Note that there are probably better ways to track this information, for example we could do some tracking on the constructor functions; this will however require serious changes in TurboFan and the runtime, and would block progress on more important tasks. R=mythria@chromium.org BUG=v8:5517 Committed: https://crrev.com/8791f01bb1bd5600976574843609a106d9e92571 Cr-Commit-Position: refs/heads/master@{#40337}

Patch Set 1 #

Patch Set 2 : REGOLDEN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-17 06:32:57 UTC) #1
Benedikt Meurer
Hey Mythri, Here's a simple one-liner to enable feedback on super constructor calls, for Ignition ...
4 years, 2 months ago (2016-10-17 06:33:42 UTC) #4
mythria
Great. Ignition going ahead of FCG in collecting feedback. :) LGTM.
4 years, 2 months ago (2016-10-17 06:40:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419423002/20001
4 years, 2 months ago (2016-10-17 06:49:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 07:57:24 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 07:57:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8791f01bb1bd5600976574843609a106d9e92571
Cr-Commit-Position: refs/heads/master@{#40337}

Powered by Google App Engine
This is Rietveld 408576698