Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3540)

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 2419413002: Deleted CONTENT_SETTINGS_TYPE_FULLSCREEN and MOUSELOCK. (Closed)
Patch Set: Fix more things. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
index fa9082808b59cbde01ad50eb0adf1cc372987f3c..829f061c67d8a5eec14d2ea3f3899dfc0a538080 100644
--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
@@ -164,24 +164,13 @@ TEST_F(PrefProviderTest, DiscardObsoletePreferences) {
PrefProvider provider(prefs, false);
provider.ShutdownOnUIThread();
- // Check that fullscreen and mouselock have been reset back to defaults.
- // TODO(mgiuca): These should be fully deleted, except that they keep being
- // recreated due to the content settings enum still existing. Delete the enum,
- // then update this test to expect full deletion. https://crbug.com/591896.
- // EXPECT_FALSE(prefs->HasPrefPath(kFullscreenPrefPath));
- // EXPECT_FALSE(prefs->HasPrefPath(kMouselockPrefPath));
- GURL primary_url("http://example.com/");
- EXPECT_EQ(CONTENT_SETTING_DEFAULT,
- TestUtils::GetContentSetting(&provider, primary_url, primary_url,
- CONTENT_SETTINGS_TYPE_FULLSCREEN,
- std::string(), false));
+ // Check that fullscreen and mouselock have been deleted.
+ EXPECT_FALSE(prefs->HasPrefPath(kFullscreenPrefPath));
#if !defined(OS_ANDROID)
- EXPECT_EQ(CONTENT_SETTING_DEFAULT,
- TestUtils::GetContentSetting(&provider, primary_url, primary_url,
- CONTENT_SETTINGS_TYPE_MOUSELOCK,
- std::string(), false));
+ EXPECT_FALSE(prefs->HasPrefPath(kMouselockPrefPath));
#endif
EXPECT_TRUE(prefs->HasPrefPath(kGeolocationPrefPath));
+ GURL primary_url("http://example.com/");
EXPECT_EQ(CONTENT_SETTING_ALLOW,
TestUtils::GetContentSetting(&provider, primary_url, primary_url,
CONTENT_SETTINGS_TYPE_GEOLOCATION,

Powered by Google App Engine
This is Rietveld 408576698