Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

This patch removes the updateStyleAndLayout calls from the above mentioned
functions for the following reasons.

The clean layout generated by the call in Editor::appliedEditing is only used
by spell checker. However, that spell checker requires clean layout is an
implementation detail and should not be exposed to callers. This patch moves
the call into spell checker.

The two calls in Editor::{un,re}appliedEditing appear to be useless as they
are immediately followed by event dispatching, which does not require clean
layout but may make the layout dirty again. So they are removed by this patch.

BUG=590369
Committed: https://crrev.com/2363de77aa3111cbd8fa2f270c22e8d44cf0f77e
Cr-Commit-Position: refs/heads/master@{#426167}

[Xiaocheng, 2016-10-18 08:48:06]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 08:48:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 10:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 10:57:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2016-10-19 02:52:15]

Description was changed from

==========
Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

BUG=590369
==========

to

==========
Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

This patch removes the updateStyleAndLayout calls from the above mentioned
functions for the following reasons.

The clean layout generated by the call in Editor::appliedEditing is only used
by spell checker. However, that spell checker requires clean layout is an
implementation detail and should not be exposed to callers. This patch moves
the call into spell checker.

The two calls in Editor::{un,re}appliedEditing appear to be useless as they
are immediately followed by event dispatching, which does not require clean
layout but may make the layout dirty again.

BUG=590369
==========

[Xiaocheng, 2016-10-19 02:52:30]

Description was changed from

==========
Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

This patch removes the updateStyleAndLayout calls from the above mentioned
functions for the following reasons.

The clean layout generated by the call in Editor::appliedEditing is only used
by spell checker. However, that spell checker requires clean layout is an
implementation detail and should not be exposed to callers. This patch moves
the call into spell checker.

The two calls in Editor::{un,re}appliedEditing appear to be useless as they
are immediately followed by event dispatching, which does not require clean
layout but may make the layout dirty again.

BUG=590369
==========

to

==========
Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

This patch removes the updateStyleAndLayout calls from the above mentioned
functions for the following reasons.

The clean layout generated by the call in Editor::appliedEditing is only used
by spell checker. However, that spell checker requires clean layout is an
implementation detail and should not be exposed to callers. This patch moves
the call into spell checker.

The two calls in Editor::{un,re}appliedEditing appear to be useless as they
are immediately followed by event dispatching, which does not require clean
layout but may make the layout dirty again. So they are removed by this patch.

BUG=590369
==========

[Xiaocheng, 2016-10-19 03:44:50]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-19 03:44:51]

PTAL.

[yosin_UTC9, 2016-10-19 03:46:52]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-19 03:46:53]

lgtm

[commit-bot: I haz the power, 2016-10-19 03:47:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 06:00:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 06:00:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Xiaocheng, 2016-10-19 10:29:11]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-10-19 10:30:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 13:05:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:07:35]

Description was changed from

==========
Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

This patch removes the updateStyleAndLayout calls from the above mentioned
functions for the following reasons.

The clean layout generated by the call in Editor::appliedEditing is only used
by spell checker. However, that spell checker requires clean layout is an
implementation detail and should not be exposed to callers. This patch moves
the call into spell checker.

The two calls in Editor::{un,re}appliedEditing appear to be useless as they
are immediately followed by event dispatching, which does not require clean
layout but may make the layout dirty again. So they are removed by this patch.

BUG=590369
==========

to

==========
Remove layout updates from Editor::{applied,unapplied,reapplied}Editing

This patch removes the updateStyleAndLayout calls from the above mentioned
functions for the following reasons.

The clean layout generated by the call in Editor::appliedEditing is only used
by spell checker. However, that spell checker requires clean layout is an
implementation detail and should not be exposed to callers. This patch moves
the call into spell checker.

The two calls in Editor::{un,re}appliedEditing appear to be useless as they
are immediately followed by event dispatching, which does not require clean
layout but may make the layout dirty again. So they are removed by this patch.

BUG=590369

Committed: https://crrev.com/2363de77aa3111cbd8fa2f270c22e8d44cf0f77e
Cr-Commit-Position: refs/heads/master@{#426167}
==========

[commit-bot: I haz the power, 2016-10-21 13:07:36]

Patchset 1 (id:??) landed as
https://crrev.com/2363de77aa3111cbd8fa2f270c22e8d44cf0f77e
Cr-Commit-Position: refs/heads/master@{#426167}