Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: chrome/browser/ui/cocoa/notifications/xpc_service_main.mm

Issue 2419213003: Ensure the xpc transaction is ended (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/notifications/xpc_service_main.mm
diff --git a/chrome/browser/ui/cocoa/notifications/xpc_service_main.mm b/chrome/browser/ui/cocoa/notifications/xpc_service_main.mm
index f36fe9b78ca1e3cafec8d0dfdd909812480e5c2c..4052ac63e642bc975c483f7be112259168b20ccf 100644
--- a/chrome/browser/ui/cocoa/notifications/xpc_service_main.mm
+++ b/chrome/browser/ui/cocoa/notifications/xpc_service_main.mm
@@ -21,11 +21,6 @@ int main(int argc, const char* argv[]) {
NSXPCListener* listener = [NSXPCListener serviceListener];
listener.delegate = delegate.get();
- // Keep the connection open forever since there is no xpc_transaction_end()
- // TODO(miguelg): send xpc_transaction_end when no alerts are being
- // displayed.
- xpc_transaction_begin();
-
[listener resume];
return 0;

Powered by Google App Engine
This is Rietveld 408576698