Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2419183002: Update AOT Android harness for single-file app snapshots. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 5772e44bd50d39f78d8c7b52c682ad296f7fa165..05f06a2c2a2e6c7595a0534d06978e8b952949c6 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2607,23 +2607,20 @@ class CommandExecutorImpl implements CommandExecutor {
.runAdbCommand(['push', '$testdir/$file', '$deviceTestDir/$file']));
}
- if (command.useBlobs) {
- steps.add(() => device.runAdbShellCommand(
- [
- '$devicedir/dart_precompiled_runtime',
- '--run-app-snapshot=$deviceTestDir',
- '--use-blobs'
- ]..addAll(arguments),
- timeout: timeoutDuration));
- } else {
- steps.add(() => device.runAdbShellCommand(
- [
- '$devicedir/dart_precompiled_runtime',
- '--run-app-snapshot=$deviceTestDir'
- ]..addAll(arguments),
- timeout: timeoutDuration));
+ var args = new List();
+ args.addAll(arguments);
+ for (var i = 0; i < args.length; i++) {
+ if (args[i].endsWith(".dart")) {
+ args[i] = "$deviceTestDir/out.aotsnapshot";
+ }
}
+ steps.add(() => device.runAdbShellCommand(
+ [
+ '$devicedir/dart_precompiled_runtime',
+ ]..addAll(args),
+ timeout: timeoutDuration));
+
var stopwatch = new Stopwatch()..start();
var writer = new StringBuffer();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698