Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2419133002: Revert of Use passed-in --build-dir instead of GetBuildOutputDirectory in ... (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, pfeldman
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. (patchset #4 id:60001 of https://codereview.chromium.org/2420543002/ ) Reason for revert: I think this could have possibly caused http://crbug.com/656063, so speculatively reverting Original issue's description: > Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. > > BUG=655798 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/072fdd58f2070edbb909079ff8523ce6a38c8d65 TBR=dpranke@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=655798 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c145d9bf6bf6d333036c6b66f3fa58089b1e12ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M scripts/slave/chromium/archive_layout_test_results.py View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
qyearsley
Created Revert of Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py.
4 years, 2 months ago (2016-10-14 18:18:07 UTC) #2
Dirk Pranke
4 years, 2 months ago (2016-10-14 19:15:33 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698