Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2419093002: Revert of Preserving Content-Type header from http request in OpenURL path. (Closed)

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
4 years, 2 months ago
Reviewers:
Charlie Reis, nasko, mmenke
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Preserving Content-Type header from http request in OpenURL path. (patchset #13 id:240001 of https://codereview.chromium.org/2355023002/ ) Reason for revert: This CL caused a regression - https://crbug.com/655568. Original issue's description: > Preserving extra http request headers in OpenURL navigation path. > > This CL makes sure that extra http request headers (e.g. in case of HTTP > POST, the Content-Type: multipart/form-data; boundary=... header) are > preserved when navigation uses the "OpenURL" code path. > > BUG=648648 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/f097ee58fe6bb4c329999f03253bc4849cc50302 > Cr-Commit-Position: refs/heads/master@{#424588} TBR=creis@chromium.org,nasko@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=648648 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/375969abb781814249ca4666b90a916f52b15fa2 Cr-Commit-Position: refs/heads/master@{#425473}

Patch Set 1 #

Patch Set 2 : Manually resolved conflicts with r425338 in navigator_impl.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -150 lines) Patch
M chrome/browser/prerender/prerender_manager.cc View 1 4 chunks +2 lines, -25 lines 0 comments Download
M content/browser/frame_host/navigator.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 1 chunk +11 lines, -12 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 6 chunks +3 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 8 chunks +6 lines, -12 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Łukasz Anforowicz
Created Revert of Preserving Content-Type header from http request in OpenURL path.
4 years, 2 months ago (2016-10-14 15:22:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419093002/1
4 years, 2 months ago (2016-10-14 15:23:08 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/browser/frame_host/navigator_impl.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-14 16:48:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419093002/1
4 years, 2 months ago (2016-10-14 18:35:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/281570)
4 years, 2 months ago (2016-10-14 18:47:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419093002/230001
4 years, 2 months ago (2016-10-14 20:15:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:230001)
4 years, 2 months ago (2016-10-14 21:37:12 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 21:40:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/375969abb781814249ca4666b90a916f52b15fa2
Cr-Commit-Position: refs/heads/master@{#425473}

Powered by Google App Engine
This is Rietveld 408576698