Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2419043002: Document deprecated plugin policies as such. (Closed)

Created:
4 years, 2 months ago by pastarmovj
Modified:
4 years, 2 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, tnagel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document deprecated plugin policies as such. EnabledPlugins, DisabledPlugins and DisabledPluginsExcpetions are deprecated as part of the general plugins handling framework deprecation effort. BUG=654731 TEST=none - Documentation only change. Committed: https://crrev.com/231648330ec3ea62f4a238024b6d2e727a16f75c Cr-Commit-Position: refs/heads/master@{#425640}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments. #

Patch Set 3 : Rename ph-s. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M components/policy/resources/policy_templates.json View 1 2 6 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pastarmovj
Please review this cl at your convenience. Thanks!
4 years, 2 months ago (2016-10-14 12:24:51 UTC) #2
Thiemo Nagel
https://codereview.chromium.org/2419043002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2419043002/diff/1/components/policy/resources/policy_templates.json#newcode1347 components/policy/resources/policy_templates.json:1347: 'desc': '''This policy is deprecated. Please use the DefaultPluginsSetting ...
4 years, 2 months ago (2016-10-14 12:28:19 UTC) #3
pastarmovj
https://codereview.chromium.org/2419043002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2419043002/diff/1/components/policy/resources/policy_templates.json#newcode1347 components/policy/resources/policy_templates.json:1347: 'desc': '''This policy is deprecated. Please use the DefaultPluginsSetting ...
4 years, 2 months ago (2016-10-14 12:45:49 UTC) #4
Thiemo Nagel
Lgtm https://codereview.chromium.org/2419043002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2419043002/diff/1/components/policy/resources/policy_templates.json#newcode1347 components/policy/resources/policy_templates.json:1347: 'desc': '''This policy is deprecated. Please use the ...
4 years, 2 months ago (2016-10-14 14:22:53 UTC) #5
pastarmovj
Done. Thanks!
4 years, 2 months ago (2016-10-17 08:39:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419043002/40001
4 years, 2 months ago (2016-10-17 08:39:40 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 09:24:12 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:26:39 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/231648330ec3ea62f4a238024b6d2e727a16f75c
Cr-Commit-Position: refs/heads/master@{#425640}

Powered by Google App Engine
This is Rietveld 408576698