[Android] Check list length before printing forwarder information.

telemetry/telemetry/internal/platform/android_platform_backend.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import posixpath
 import re
 import subprocess
 import tempfile
@@ skipping 466 matching lines @@
     old_flag = self._device.GetProp('socket.relaxsslcheck')
     self._device.SetProp('socket.relaxsslcheck', value)
     return old_flag
 
   def ForwardHostToDevice(self, host_port, device_port):
     self._device.adb.Forward('tcp:%d' % host_port, device_port)
 
   def StopForwardingHost(self, host_port):
     for line in self._device.adb.ForwardList().strip().splitlines():
       line = line.split(' ')
-      if line[0] == self._device and line[1] == 'tcp:%s' % host_port:
-        self._device.adb.ForwardRemove('tcp:%d' % host_port)
-        break
+      if len(line) >= 2:
+        if line[0] == self._device and line[1] == 'tcp:%s' % host_port:
+          self._device.adb.ForwardRemove('tcp:%d' % host_port)
+          break
+      else:
+        logging.warning('Attempted to split line in StopForwardingHost method, '
+                        'but outcome was unexpected:\n%s' % line)

[mikecase (-- gone --), 2016/10/14 16:58:13]

nit: I would reword this error message to something like...

'ADB forward list output unexpected. Expected format "<device id> tcp:<host
port>" but got %s' % line

Up to you though

[rnephew (Reviews Here), 2016/10/14 17:06:41]

Done.

     else:
       logging.warning('Port %s not found in adb forward --list for device %s',
                       host_port, self._device)
 
   def DismissCrashDialogIfNeeded(self):
     """Dismiss any error dialogs.
 
     Limit the number in case we have an error loop or we are failing to dismiss.
     """
     for _ in xrange(10):
@@ skipping 275 matching lines @@
   for process in psutil.process_iter():
     try:
       if psutil.version_info >= (2, 0):
         if 'adb' in process.name():
           process.cpu_affinity([0])
       else:
         if 'adb' in process.name:
           process.set_cpu_affinity([0])
     except (psutil.NoSuchProcess, psutil.AccessDenied):
       logging.warn('Failed to set adb process CPU affinity')